Update to use revised version of the font #1489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a revised version of the v2 font introduced in 0f0dc41. The vertical metric for the woff and woff-2 web fonts has now been adjusted in order to center the cap height vertically in a html element (for all browsers) as we’re seeing alignment issues across all browers on Windows. The previous version of the ‘v2’ font has not been released yet.
NickColley
approved these changes
Jul 11, 2019
There was a problem hiding this comment.
I've checked the shas in the filenames match https://github.com/alphagov/fonts/tree/master/fonts/v2/unhinted 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a revised version of the v2 font introduced in 0f0dc41 (#1434).
The vertical metric for the woff and woff-2 web fonts has now been adjusted in order to center the cap height vertically in a html element (for all browsers) as we’re seeing alignment issues across all browsers on Windows.
The previous version of the ‘v2’ font has not been released yet.
Fixes #1486