Change position and spacing relationship of warning text icon #1578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1578
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1578
|
Browserstack screenshots: |
|
This makes sense to me – just needs a changelog entry. |
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1578
36degrees
approved these changes
Sep 20, 2019
36degrees
force-pushed
the
update-warning-text-icon-position
branch
from
6eb727f
to
4e7d8c3
Compare
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses - #1352
The primary purpose of the this PR was to align the icon with the top line, so that when the content wraps the icon doesn't vertically align with the entire block and potentially end up out of sight when the user starts reading the warning text.
To do this I had to also reduce the size of the icon slightly, and reduce the gap between the icon and the text accordingly.
It may seem a random size (29px) but this is helped it align with the first line, 30px created an unequal distribution of space.
Before: Single line
Before: Wrapping
After: Single line
After: Wrapping
I also removed some of the (I think) New Transport adjustments.