Do not output conditionally revealed content for radios or checkboxes when it's empty #1595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1595
36degrees
force-pushed
the
omit-empty-conditionals
branch
from
1cbb063 to
08c96e0
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1595
If `item.conditional.html` is falsy, perhaps because it’s referencing a variable that is conditionally assigned, the macro currently outputs an empty `div.govuk-checkboxes__conditional` and associates it with the input using aria-controls. By testing for `item.conditional.html` being truthy (which is the only property in the item.conditional object used within the macro) we can avoid this.
36degrees
force-pushed
the
omit-empty-conditionals
branch
from
08c96e0 to
c708087
Compare
NickColley
approved these changes
Sep 27, 2019
|
Woop! 🎉 |
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
item.conditional.htmlis falsy, perhaps because it’s referencing a variable that is conditionally assigned, the macro currently outputs an emptydiv.govuk-checkboxes__conditionaland associates it with the input using aria-controls.By testing for
item.conditional.htmlbeing truthy (which is the only property in the item.conditional object used within the macro) we can avoid this.Fixes #1546