Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update hex value for secondary text to improve contrast #1609

Merged
merged 4 commits into from
Oct 9, 2019

Conversation

DebsDee
Copy link
Contributor

@DebsDee DebsDee commented Oct 9, 2019

Fixes in this PR

The secondary text colour value has been updated to improve the contrast of components that use the govuk-colour("dark-grey") sass variable. The value has been updated from #6f777b to #626a6e

This is a small incremental change that improves the contrast ratio from 4.56:1 to 5.51:1.

Fixes #1134

Fixes in this PR

The secondary text colour value has been updated to improve the
constrast of components that use the ```govuk-colour("dark-grey")```
sass variable. The value has been updated from ```#6f777b``` to
```626a6e```

Fixes #1134
Fixes in this PR

The secondary text colour value has been updated to improve the
contrast of components that use the ```govuk-colour("dark-grey")```
sass variable. The value has been updated from ```#6f777b``` to ```#626a6e```

This is a small incremental change that improves the contrast ratio from 4.56:1 to 5.51:1.

Fixes #1134
@DebsDee DebsDee requested a review from 36degrees October 9, 2019 15:08
@NickColley NickColley added this to the Next milestone Oct 9, 2019
@DebsDee DebsDee merged commit aa30ee7 into master Oct 9, 2019
@DebsDee DebsDee deleted the secondary-text-colour branch October 9, 2019 16:06
36degrees added a commit that referenced this pull request Nov 5, 2019
This was accidentally added to the changelog for 3.3.0 after the release had been made – we've yet to release it, so it should be included in the unreleased section.
36degrees added a commit that referenced this pull request Nov 6, 2019
@36degrees 36degrees removed this from the v3.4.0 milestone Nov 7, 2019
m-green pushed a commit that referenced this pull request Nov 13, 2019
This was accidentally added to the changelog for 3.3.0 after the release had been made – we've yet to release it, so it should be included in the unreleased section.
@NickColley NickColley added this to the v3.4.0 milestone Nov 13, 2019
@36degrees 36degrees mentioned this pull request Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Investigate colour contrast issues with secondary text colour
4 participants