Only add underline to back link when href exists #1620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"Browser default behaviour is to underline anchors only when an href is provided. This is to ensure users can identify links on a page (an anchor without an href is not considered a link by default). This feature also has the side effect of helping developers realise that they may have missed an href attribute - as they can visually see on the page that a link is not underlined." Fixes #1171
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1620
hannalaakso
reviewed
Oct 28, 2019
Looking at the spec, '[if] the |
|
@hannalaakso how do you feel about following the spec? |
Merged
penx
added a commit
to govuk-react/govuk-react
that referenced
this pull request
May 22, 2021
Fixes: #449 Revist: #1171 To match: alphagov/govuk-frontend#1620 React Router would provide an href. If no href is provided, the absense of an underline would be a prompt for the developer to add one. This mirrors user agent stylesheets for an anchor.
penx
added a commit
to govuk-react/govuk-react
that referenced
this pull request
May 24, 2021
Fixes: #449 Revist: #1171 To match: alphagov/govuk-frontend#1620 React Router would provide an href. If no href is provided, the absense of an underline would be a prompt for the developer to add one. This mirrors user agent stylesheets for an anchor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"Browser default behaviour is to underline anchors only when an href is provided. This is to ensure users can identify links on a page (an anchor without an href is not considered a link by default).
This feature also has the side effect of helping developers realise that
they may have missed an href attribute - as they can visually see on the
page that a link is not underlined."
Fixes #1171