Deprecate iff function #1742
Merged
Deprecate iff function #1742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- make the function a private function to indicate it should not be used. - add warning and deprecation sassdoc to indicate it will be removed in the future. #1735
This is not needed and now deprecated.
hannalaakso
approved these changes
Mar 4, 2020
Merged
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
used.
the future.
My main motivation for this is to ensure the Sassdocs output with only what we want users to use as they'll be public soon.
This pull request marks the function as deprecated without removing it, meaning we can give users a heads up before getting rid of it.
It also assigns it as 'private' which'll prevent it from being output in our Sassdocs output.
Related: #1735