Fix the display of checkboxes when border-box box sizing is applied globally #1861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a user applies a global box-sizing reset [1], the checkmarks shrink towards the top left corner of the box. The ::before pseudo-element already uses `box-sizing: border-box`, so update the `::after` pseudo element to use border-box sizing model in order to be consistent. As the box-sizing model is now set explicitly, it should display correctly whether the reset is applied or not. Increase the width and height of the pseudo elements to include the border widths to accomodate the width of the border (adding an additional 5px to the width and height of normal-sized checkboxes, and 3px to smaller ones). Switch out the use of `$govuk-border-width` for a hardcoded 5px width for the check marks, as we don't currently factor this in when positioning the check mark, which means if you change the border width setting the checkbox will no longer be centered (I also just don't think it makes sense to tie the width of the check marks to the border width?) [1]: https://css-tricks.com/inheriting-box-sizing-probably-slightly-better-best-practice/
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1861
36degrees
changed the title
36degrees
changed the title
vanitabarrett
approved these changes
Jul 16, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a user applies a global box-sizing reset, the checkmarks shrink towards the top left corner of the box.
The ::before pseudo-element already uses
box-sizing: border-box, so update the::afterpseudo element to use border-box sizing model in order to be consistent. As the box-sizing model is now set explicitly, it should display correctly whether the reset is applied or not.Increase the width and height of the pseudo elements to include the border widths to accomodate the width of the border (adding an additional 5px to the width and height of normal-sized checkboxes, and 3px to smaller ones).
Switch out the use of
$govuk-border-widthfor a hardcoded 5px width for the check marks, as we don't currently factor this in when positioning the check mark, which means if you change the border width setting the checkbox will no longer be centered (I also just don't think it makes sense to tie the width of the check marks to the border width?)Fixes #1849
Before
After