Preserve the state of character count when navigating 'back' #1868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1868
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1868
36degrees
approved these changes
Jul 16, 2020
vanitabarrett
force-pushed
the
update-character-count-back
branch
from
199d29f
to
b0b5d5e
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1868
36degrees
reviewed
Jul 16, 2020
| this.sync() | ||
| } | ||
|
|
||
| CharacterCount.prototype.sync = function () { |
vanitabarrett
force-pushed
the
update-character-count-back
branch
from
b0b5d5e
to
ee817e3
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1868
vanitabarrett
force-pushed
the
update-character-count-back
branch
from
ee817e3
to
5a344b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1848
What
When the user navigates back to a previous page that includes a character count, the character count message should reflect the text currently in the textarea.
Why
Fix based on #1842
Previously, when navigating back to a page with a character count, the character count message wouldn't update (reflect the text currently in the textarea) until the textarea received focus.
Current behaviour: http://govuk-frontend-review.herokuapp.com/full-page-examples/feedback
Preview new behaviour: https://govuk-frontend-review-pr-1868.herokuapp.com/full-page-examples/feedback
Notes
On slow connections there may be a flash of the default character count text before it updates. From testing with a 4x CPU slowdown, the default text may show for 0.03s before it updates. Given how small this is even with slowdown, we've decided to leave it as-is. If we decide this is an issue in the future, we'd also need to look at other components (e.g: radios and checkboxes) which are affected in a similar way.
Browser testing