Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for a couple of component examples / fixtures #2043

Merged
merged 5 commits into from
Dec 15, 2020
Merged

Fixes for a couple of component examples / fixtures #2043

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6deb199
Fix invalid legend on the checkbox component's 'fieldset params' example
andymantell Nov 26, 2020
d824b00
Mark 'value' as required under each option of a select component
andymantell Nov 26, 2020
5ce3905
Update jest snapshot for tweaked checkboxes example
andymantell Nov 26, 2020
9a6eb48
Add missing value to checkboxes multiple hints example
andymantell Nov 26, 2020
beb0e6d
Unmark select component option values as required
andymantell Dec 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/govuk/components/checkboxes/__snapshots__/template.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@ exports[`Checkboxes nested dependant components passes through fieldset params w
data-attribute="value"
data-second-attribute="second-value"
>
<legend class="govuk-fieldset__legend">
What is your nationality?
</legend>
</fieldset>
`;

Expand Down
7 changes: 4 additions & 3 deletions src/govuk/components/checkboxes/checkboxes.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -658,7 +658,8 @@ examples:
text: Hint for british option here
- value: irish
text: Irish
- hint:
- value: other
hint:
text: Hint for other option here
- name: with error message and hint
hidden: true
Expand Down Expand Up @@ -710,9 +711,9 @@ examples:
name: example-name
errorMessage:
text: Please select an option
legend:
text: What is your nationality?
fieldset:
legend:
text: What is your nationality?
classes: app-fieldset--custom-modifier
attributes:
data-attribute: value
Expand Down
4 changes: 4 additions & 0 deletions src/govuk/components/select/select.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,11 +205,13 @@ examples:
items:
-
text: Option 1
value: 1
attributes:
data-attribute: ABC
data-second-attribute: DEF
-
text: Option 2
value: 2
attributes:
data-attribute: GHI
data-second-attribute: JKL
Expand All @@ -221,11 +223,13 @@ examples:
items:
-
text: Option 1
value: 1
- null
- false
- ""
-
text: Options 2
value: 2
- name: hint
hidden: true
data:
Expand Down