-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve vertical alignment of phase banner tag on mobile devices #2132
Improve vertical alignment of phase banner tag on mobile devices #2132
Conversation
Hello, did we have any thoughts around this? Any concerns? |
Hi @matthewmascord - sorry for the delay in getting back. We're really keen to avoid any additional markup changes if possible, as that would then be a breaking change. Do you think there's a way of achieving something similar without the additional span? |
Thanks @timpaul , interesting question, I can certainly look into that. I didn't realise adding markup was always a breaking change - what makes it breaking exactly? |
Hello @timpaul, I've simplified the solution removing the markup changes and retested on the above devices. It turned out that the solution was backwards compatible for HTML users with no markup changes because the default behaviour without the additional span with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@matthewmascord I am approving this suggestion, thank you for making it and testing it across browsers.
This pull request improves vertical alignment of phase banner tag on mobile devices
Adding pull request #2132 to change log
This PR is designed to improve the vertical alignment of the phase banner tag when viewed on mobile devices. Following consultation with @timpaul and @christopherthomasdesign it was agreed that the desired behaviour should be:
In order to fix this problem, it was necessary to wrap the tag element in a SPAN with
display: table-cell
, allowing the vertical alignment of the tag to be controlled.Before:
After:
Tested on:
Windows 7, IE8
Windows 7, IE9
Windows 7, IE10
Windows 10, IE11
Windows 10, Firefox 84
Windows 10, Chrome 88
Windows 10, Edge 88
Galaxy S8, Android 7, Chrome
Galaxy S8, Android 7, Samsung Internet
iPhone 8, iOS 13, Safari
iPhone 8, iOS 13, Chrome
macOS Catalina, Firefox 85
macOS Catalina, Safari 14
macOS Catalina, Chrome 88