Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "None of these" and "or" divider to checkboxes #2151

Merged
merged 5 commits into from
Jun 18, 2021
Merged

Add "None of these" and "or" divider to checkboxes #2151

merged 5 commits into from
Jun 18, 2021
+249 −42

Commits on Jun 18, 2021

  1. Add divider to checkboxes

    @frankieroberto
    frankieroberto committed Jun 18, 2021
    Configuration menu
    Copy the full SHA
    4abfcd8 View commit details
    Browse the repository at this point in the history

  2. Add data attribute to HTML for behaviour, and always insert data-modu… 

    …le attribute.

This fixes a bug/edge-case where if you use two separate calls to the macro within the same `<form>` and specify the same `name` attribute value for both sets of checkboxes, but only one of them has the `exclusive` behaviour or the conditional content, then checking a checkbox in one list would not uncheck the "None" checkbox in the other list, as there was no `eventListener` set up.

Always initialising the javascript for every set of checkboxes solves this.

This does introduce a small performance penalty of potentially initialising javascript when it's not needed, but this should be negligible and non-blocking.
    @frankieroberto
    frankieroberto committed Jun 18, 2021
    Configuration menu
    Copy the full SHA
    7e746b4 View commit details
    Browse the repository at this point in the history

  3. Add documentation for new feature

    @frankieroberto
    frankieroberto committed Jun 18, 2021
    Configuration menu
    Copy the full SHA
    fad5263 View commit details
    Browse the repository at this point in the history

  4. Add javascript behaviour and tests

    @frankieroberto
    frankieroberto committed Jun 18, 2021
    Configuration menu
    Copy the full SHA
    90d7f26 View commit details
    Browse the repository at this point in the history

  5. Add template tests

    @frankieroberto
    frankieroberto committed Jun 18, 2021
    Configuration menu
    Copy the full SHA
    1042a8e View commit details
    Browse the repository at this point in the history