Add inverse link mixin and modifier class #2213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@36degrees Change looks good, but I'm not sure 6199cfd belongs in this PR? |
36degrees
force-pushed
the
inverse-link-mixin
branch
from
312e1cd
to
3e4108b
Compare
Good shout – rebased to remove it. |
vanitabarrett
approved these changes
Apr 30, 2021
Inverse links are a fairly common thing for service teams to need to implement, and we often see issues with the focus state being implemented incorrectly. The upcoming changes to link styles will add even more nuance, so providing a reusable mixin and modifier class will save users time and help to make it more likely that link styles are implemented well. We can also use this new mixin when we update the header component.
36degrees
force-pushed
the
inverse-link-mixin
branch
from
3e4108b
to
2dbff2b
Compare
12 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inverse links are a fairly common thing for service teams to need to implement, and we often see issues with the focus state being implemented incorrectly.
The upcoming changes to link styles will add even more nuance, so providing a reusable mixin and modifier class will save users time and help to make it more likely that link styles are implemented well.
We can also use this new mixin when we update the header component.
Closes #1916
Split out from #2183.