Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable ink skipping for underlines in hover state #2251

Merged
merged 2 commits into from
Jun 16, 2021
Merged

Disable ink skipping for underlines in hover state #2251

merged 2 commits into from
Jun 16, 2021

Commits on Jun 14, 2021

  1. Disable ink skipping for underlines in hover state 

    The thick underlines we use in the new hover states are rendered
differently by different browsers. In Safari and Firefox, links can
look messy if the link text contains words with lots of descenders.

Disable ink skipping on hover, which means that links look closer to the
way they do in Safari currently.

Use both `text-decoration-skip-ink: none;` and `text-decoration-skip: none;`
– Safari supports `text-decoration-skip` whilst other browsers support
`text-decoration-skip-ink`. Fun!
    @36degrees
    Chris Thomas authored and 36degrees committed Jun 14, 2021
    Configuration menu
    Copy the full SHA
    e873ed5 View commit details
    Browse the repository at this point in the history

  2. Document in CHANGELOG

    @36degrees
    36degrees committed Jun 14, 2021
    Configuration menu
    Copy the full SHA
    208711c View commit details
    Browse the repository at this point in the history