Improve support for Internet Explorer 11 with Windows High Contrast Mode #2290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
lfdebrux
force-pushed
the
ldeb-improve-ie11-hcm
branch
from
b6263cf
to
2d1b5fa
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-2290
lfdebrux
force-pushed
the
ldeb-improve-ie11-hcm
branch
from
2d1b5fa
to
0fd9fa8
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-2290
lfdebrux
force-pushed
the
ldeb-improve-ie11-hcm
branch
from
0fd9fa8
to
cc8c70b
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-2290
lfdebrux
force-pushed
the
ldeb-improve-ie11-hcm
branch
from
cc8c70b
to
7f78f81
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-2290
lfdebrux
force-pushed
the
ldeb-improve-ie11-hcm
branch
from
7f78f81
to
4b4882a
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-2290
vanitabarrett
approved these changes
Aug 20, 2021
Adds IE11 support to the previous Windows High Contrast Mode fixes in PR Internet Explorer 11 doesn't support the `forced-colors` media feature or the `forced-color-adjust` property, but it has equivalents in `-ms-high-contrast` and `-ms-high-contrast-adjust`. We can use those CSS features to extend fixes to high contrast mode that previously only worked on more modern browsers. Adds a tweak to changes in commit 7dcba7d, so that the highlight works in Internet Explorer 11 as well.
lfdebrux
force-pushed
the
ldeb-improve-ie11-hcm
branch
from
4b4882a
to
53ca3eb
Compare
|
Just added a changelog line to this commit! |
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-2290
EoinShaughnessy
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for IE11 to the previous Windows High Contrast Mode fixes in PR #2264.
Internet Explorer 11 doesn't support the
forced-colorsmedia feature or theforced-color-adjustproperty, but it has equivalents in-ms-high-contrastand-ms-high-contrast-adjust. We can use those CSS features to extend fixes to high contrast mode that previously only worked on more modern browsers.There are a couple of other places in our codebase where we have fixes for forced color mode (see PRs #2186, #2237), but the problems they fix don't seem to be present in IE11 (I think because it doesn't have a readability backplate), so I left those lines alone.