Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create resize-text-in-browsers.md #2304

Merged
merged 1 commit into from
Aug 11, 2021
Merged

Conversation

EoinShaughnessy
Copy link
Contributor

@EoinShaughnessy EoinShaughnessy commented Aug 11, 2021

What we're adding

This PR fixes #2294 and adds a new document ('Resize text in browsers') to the 'Contributing' folder in our Frontend repo.

Why we're adding it

Before users can successfully submit a component to the GOV.UK Design System, they need to make sure the component's text displays correctly when resized in different browsers. So, we created this doc to tell them the necessary steps in Chrome, Firefox, Internet Explorer, etc.

Origin of browser instructions

In the future, we may need to update the doc's content because of changes in browser functionality. If so, then we can adapt content from these links:

@EoinShaughnessy EoinShaughnessy added the documentation User requests new documentation or improvements to existing documentation label Aug 11, 2021
@EoinShaughnessy EoinShaughnessy self-assigned this Aug 11, 2021
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-2304 August 11, 2021 07:05 Inactive
@EoinShaughnessy
Copy link
Contributor Author

The content in this PR has passed both internal review and 2i.

@EoinShaughnessy EoinShaughnessy added the 🕔 hours A well understood issue which we expect to take less than a day to resolve. label Aug 11, 2021
Copy link
Member

@lfdebrux lfdebrux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doc looks good to me!

One small suggestion; could you add a link to where these instructions came from to the commit message? It might be helpful in future when the browsers change how they work and we need to look up the docs again 😅

@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-2304 August 11, 2021 08:49 Inactive
@EoinShaughnessy
Copy link
Contributor Author

@lfdebrux Ta for review! Will add links before merging this.

Add resize-text-in-browsers doc to Frontend repo
@EoinShaughnessy EoinShaughnessy force-pushed the EoinShaughnessy-patch-1-1 branch from 9dc5aea to aaca749 Compare August 11, 2021 09:06
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-2304 August 11, 2021 09:06 Inactive
@EoinShaughnessy EoinShaughnessy merged commit ce81ef5 into main Aug 11, 2021
@EoinShaughnessy EoinShaughnessy deleted the EoinShaughnessy-patch-1-1 branch August 11, 2021 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation User requests new documentation or improvements to existing documentation 🕔 hours A well understood issue which we expect to take less than a day to resolve.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document how to resize text in different browsers and devices
4 participants