Remove display:block on hint component
#2437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-2437
vanitabarrett
force-pushed
the
hint-remove-block-style
branch
from
0ce4cfc to
547d4ed
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-2437
vanitabarrett
force-pushed
the
hint-remove-block-style
branch
from
547d4ed to
fc7e3ab
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-2437
lfdebrux
approved these changes
Nov 22, 2021
vanitabarrett
force-pushed
the
hint-remove-block-style
branch
from
fc7e3ab to
ee3bcec
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-2437
In v3.8.0 we added the ability for block level elements to be rendered inside hints by switching from using a `span` to a `div`. However, we kept the `display: block` styling (which would now be redundant as this is the default for divs). This meant we weren't forcing users to update their HTML and we could avoid a breaking change. We now want to tidy up that redundant CSS as part of v4.0.0.
vanitabarrett
force-pushed
the
hint-remove-block-style
branch
from
ee3bcec to
cd6db6c
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-2437
Merged
peteryates
added a commit
to x-govuk/govuk-form-builder
that referenced
this pull request
Dec 18, 2021
Previously this library would render hints that were passed in as arguments (strings) within spans and those passed in via procs (usually HTML) inside divs, giving developers more flexibility in how things are displayed. In version 4.0.0 of the design system has moved towards just supporting divs and this change reflects that decision. alphagov/govuk-frontend#2437
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1856
What
Remove the
display: blockon the hint componentWhy
In v3.8.0 we added the ability for block level elements to be rendered inside hints by switching from using a
spanto adiv.However, we kept the
display: blockstyling (which would now be redundant as this is the default for divs). This meant we weren't forcing users to update their HTML and we could avoid a breaking change.We now want to tidy up that redundant CSS as part of v4.0.0.
Note: this work is related to #2083. I think we can probably safely make this change first, without making a decision on #2083. I've added a checklist item to that card to make sure we check the Changelog for this change still makes sense alongside whatever we decide in #2083.