Remove display:block
on hint component
#2437
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1856
What
Remove the
display: block
on the hint componentWhy
In v3.8.0 we added the ability for block level elements to be rendered inside hints by switching from using a
span
to adiv
.However, we kept the
display: block
styling (which would now be redundant as this is the default for divs). This meant we weren't forcing users to update their HTML and we could avoid a breaking change.We now want to tidy up that redundant CSS as part of v4.0.0.
Note: this work is related to #2083. I think we can probably safely make this change first, without making a decision on #2083. I've added a checklist item to that card to make sure we check the Changelog for this change still makes sense alongside whatever we decide in #2083.