-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add correct PR link to changelog #2440
Conversation
@EoinShaughnessy Ah, interesting, that's because I mistakenly linked to the issue rather than the pull request. If we update the link (and number) to #2426, then the titles will match. It'll need updating in the full Changelog entry on the change too - are you ok to do that? Sorry that'll change the ordering again too! |
@vanitabarrett No worries! Ta for explaining. Yeah, I can change it. |
@EoinShaughnessy Are you ok to update line 103 to match? |
@vanitabarrett Sorry, my bad - yeah, think it's updated now. |
@EoinShaughnessy Looks good, thanks for spotting that Eoin! Would you be ok to squash the commits before I approve? |
@vanitabarrett Will do! :) |
ad8985e
to
0b76d47
Compare
This PR replaces a link to an issue with a link to the actual PR. Have also removed a close bracket we don't need.