Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add correct PR link to changelog #2440

Merged
merged 1 commit into from
Nov 24, 2021
Merged

Add correct PR link to changelog #2440

merged 1 commit into from
Nov 24, 2021

Conversation

EoinShaughnessy
Copy link
Contributor

@EoinShaughnessy EoinShaughnessy commented Nov 24, 2021

This PR replaces a link to an issue with a link to the actual PR. Have also removed a close bracket we don't need.

@EoinShaughnessy EoinShaughnessy added the documentation User requests new documentation or improvements to existing documentation label Nov 24, 2021
@EoinShaughnessy EoinShaughnessy self-assigned this Nov 24, 2021
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-2440 November 24, 2021 09:31 Inactive
@EoinShaughnessy
Copy link
Contributor Author

EoinShaughnessy commented Nov 24, 2021

In our changelog, the title for #1836 is

Rename exported JavaScript modules to include component name

When you actually go to #1836, though, the title is

JavaScript modules are attached to the same global variable when imported individually

Can we change the PR title to match the changelog title?

@vanitabarrett
Copy link
Contributor

vanitabarrett commented Nov 24, 2021

@EoinShaughnessy Ah, interesting, that's because I mistakenly linked to the issue rather than the pull request. If we update the link (and number) to #2426, then the titles will match. It'll need updating in the full Changelog entry on the change too - are you ok to do that?

Sorry that'll change the ordering again too!

@EoinShaughnessy
Copy link
Contributor Author

@vanitabarrett No worries! Ta for explaining. Yeah, I can change it.

@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-2440 November 24, 2021 09:56 Inactive
@EoinShaughnessy EoinShaughnessy changed the title Move PR link to top of list and delete typo Add correct PR link to changelog Nov 24, 2021
@vanitabarrett
Copy link
Contributor

@EoinShaughnessy Are you ok to update line 103 to match?

@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-2440 November 24, 2021 10:12 Inactive
@EoinShaughnessy
Copy link
Contributor Author

@vanitabarrett Sorry, my bad - yeah, think it's updated now.

@vanitabarrett
Copy link
Contributor

@EoinShaughnessy Looks good, thanks for spotting that Eoin! Would you be ok to squash the commits before I approve?

@EoinShaughnessy
Copy link
Contributor Author

@vanitabarrett Will do! :)

@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-2440 November 24, 2021 10:17 Inactive
@vanitabarrett vanitabarrett merged commit a4b5dac into main Nov 24, 2021
@vanitabarrett vanitabarrett deleted the correct-typo branch November 24, 2021 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation User requests new documentation or improvements to existing documentation
Projects
Development

Successfully merging this pull request may close these issues.

3 participants