Add tests for the govuk-font mixin
#2474
Conversation
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-2474
|
|
||
| const results = await renderSass({ data: sass, ...sassConfig }) | ||
|
|
||
| expect(results.css.toString().trim()).toBe(outdent` |
There was a problem hiding this comment.
This is basically a 'snapshot test', but I couldn't think of a better way of doing it… this does mean that whenever anything changes in the govuk-font mixin we'll need to update this test accordingly. It's not ideal, but I think that's OK?
| expect(results.css.toString()).toContain('font-size: 12px') | ||
| expect(results.css.toString()).not.toContain('font-size: 14px') |
There was a problem hiding this comment.
This feels a little clunky, but because $size: 14 also outputs font-size: 12px (for mobile) it'd pass anyway… suggestions welcome.
| expect(css).toContain('font-feature-settings: "tnum" 1;') | ||
| expect(css).toContain(outdent` | ||
| ${outdent} | ||
| @supports (font-variant-numeric: tabular-nums) { | ||
| .foo { | ||
| font-feature-settings: normal; | ||
| font-variant-numeric: tabular-nums; } }`) |
There was a problem hiding this comment.
Thought it was worth testing for both of these, but not worth writing individual tests for them.
| expect(results.css.toString()).toContain('font-weight: 700') | ||
| }) | ||
|
|
||
| it('does not output font-weight if $weight: false', async () => { |
There was a problem hiding this comment.
@36degrees do you think it's worth having a test for an unrecognised $weight?
There was a problem hiding this comment.
Hmm, good question… at the minute it'll basically ignore $weight if it's not regularorbold. What would the assertion be for that test? Just check that the output does not contain font-weight`?
There was a problem hiding this comment.
I think so, yep. If that's the behaviour we want to keep!
There was a problem hiding this comment.
36degrees
force-pushed
the
govuk-font-mixin-tests
branch
from
86eee67
to
5e72b3f
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-2474
I noticed when looking into #2456 that we had no test coverage for the
govuk-fontmixin. Thegovuk-fontmixin does quite a lot of things – most of it handing off to the other mixins in this file – but does have responsibility for setting up things like tabular numbers.Add tests to try and cover all of the execution paths within the mixin.