Add explicit width to summary list row with 'no actions' pseudo-element #2515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…"after" When a summary list row has no actions, it gets an `after` pseudoelement that adds an empty table cell, so that row borders are drawn correctly. If the first row has no actions, it spaces itself automatically unless a width is specified for the pseudoelement. This then cascades to the rest of the summary list, and the actions column on every row takes up too much space, clipping content in other columns. This can be solved by explicitly setting a width on the pseudoelement. Additionally, we don't need this pseudoelement on widths below tablet, as the summary list cells split onto separate rows.
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-2515
|
Thank you @domoscargin 🎉 |
|
Needs a changelog entry, but otherwise this is looking good to me 👍🏻 |
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-2515
Done! |
36degrees
approved these changes
Jan 25, 2022
domoscargin
deleted the
bk-incorrect-content-width-summary-list-row-2495
branch
EoinShaughnessy
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a summary list row has no actions, it gets an
afterpseudoelement that adds an empty table cell, so that row borders are drawn correctly.If the first row has no actions, it spaces itself automatically unless a width is specified for the pseudoelement. This then cascades to the rest of the summary list, and the actions column on every row takes up too much space, clipping content in other columns.
This can be solved by explicitly setting a width on the pseudoelement.
Additionally, we don't need this pseudoelement on widths below tablet, as the summary list cells split onto separate rows.
Closes #2495