Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix select component renders with grey background in Firefox and Safari #2524

Merged
merged 2 commits into from
Feb 1, 2022
Merged

Fix select component renders with grey background in Firefox and Safari #2524

merged 2 commits into from
Feb 1, 2022

Commits on Feb 1, 2022

  1. Set background and text colour on select 

    Sets the background and foreground colours (`background-color` and `color`)
on the select component to fix #2435

We're setting both the background and foreground so we don't fail WCAG by specifying
background colours without foreground colour (https://www.w3.org/TR/WCAG20-TECHS/F24.html):
Unless an author specifies both foreground and background colors, then they (the author)
can no longer guarantee that the user will get a contrast that meets the contrast requirements.
    Vanita Barrett committed Feb 1, 2022
    Configuration menu
    Copy the full SHA
    2a91079 View commit details
    Browse the repository at this point in the history

  2. Add to changelog

    Vanita Barrett committed Feb 1, 2022
    Configuration menu
    Copy the full SHA
    506b858 View commit details
    Browse the repository at this point in the history