Add top padding to accordion section #2640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owenatgov
force-pushed
the
accordion-section-padding
branch
from
710b5cd
to
579347b
Compare
owenatgov
changed the title
owenatgov
force-pushed
the
accordion-section-padding
branch
from
579347b
to
84a4021
Compare
owenatgov
force-pushed
the
accordion-section-padding
branch
from
84a4021
to
57eafba
Compare
36degrees
approved these changes
May 24, 2022
There was a problem hiding this comment.
I think this makes sense – I did have a brief chat with @christopherthomasdesign as the section heading does feel quite far away from the content now, but given the other constraints at play there wasn't an obvious solution.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What/Why
Fixes #2608
Adds top padding to the toggleable accordion section so that the touch area between the accordion heading button and any potential touch targets within that accordion section eg: a link aren't too close together.
Visual changes
Before
Open:
Open with hover state:
After
Open:
Open with hover state:
