Fix Summary List action link alignment #2668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
querkmachine
force-pushed
the
fix-summary-list-action-alignment
branch
from
0db63e1 to
5b3b57d
Compare
vanitabarrett
approved these changes
Jun 28, 2022
|
@vanitabarrett Would this be listed as a regular fix, or do we want to provide additional guidance about removing whitespace from within list items? |
|
@querkmachine I think it would just be listed as a regular fix? If we want to tell our users how to remove whitespace if they're not using Nunjucks macros I think we should consider either 1) having the flex fix in combination with the Nunjucks whitespace fix and/or documenting it somewhere a bit more permanent than the release notes |
Adds ':first-child)' to the disallow list for postcss-pseudo-classes, so PostCSS doesn't attempt to transform it and triggers an error.
Fixes the alignment on the Summary List component action links, if there are enough links to wrap onto multiple lines. It does this by reversing the side of the link that margin, padding and borders are applied to depending on the breakpoint. On mobile, links are left aligned with spacing and borders on the right. On tablet and above, links are right aligned with spacing and borders on the left.
Fixes errant whitespace causing one side of the separators appearing larger than the other.
querkmachine
force-pushed
the
fix-summary-list-action-alignment
branch
from
f684468 to
1df31ba
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there are several action links in the Summary List component, the links become misaligned on large screens, due to the links being right-aligned and the separator being appended to the right of each link. Links are aligned correctly on narrow screens, as the links are left-aligned in that context.
Additionally, the spacing on each side of the separator is uneven due to extra whitespace being counted between each link.
This PR intends to fix these issues by:
Fixes #2281.
Comparisons
Small screens (modern browsers, IE11, IE10)
Large screens (modern browsers, IE11, IE10)
Large screens (IE9)
Flexbox is not supported by IE9, so the uneven spacing between separators is still present.
Large screens (IE8)
Neither flexbox, nor the
:first-childand:last-childpseudo-selectors, are supported in IE8.