Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v4.3.1 #2783

Merged
merged 1 commit into from
Aug 18, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

## Unreleased

## 4.3.1 (Patch release)

### Recommended changes

#### Replace deprecated `govuk-!-margin-static` and `govuk-!-padding-static` classes
Expand Down
2 changes: 1 addition & 1 deletion dist/VERSION.txt
Original file line number Diff line number Diff line change
@@ -1 +1 @@
4.3.0
4.3.1
1 change: 0 additions & 1 deletion dist/govuk-frontend-4.3.0.min.js

This file was deleted.

Large diffs are not rendered by default.

1 change: 1 addition & 0 deletions dist/govuk-frontend-4.3.1.min.js

Large diffs are not rendered by default.

Large diffs are not rendered by default.

12 changes: 1 addition & 11 deletions package/govuk-esm/components/accordion/accordion.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -301,9 +301,7 @@ var helper = {
window.sessionStorage.removeItem(testString)
return result
} catch (exception) {
if ((typeof console === 'undefined' || typeof console.log === 'undefined')) {
console.log('Notice: sessionStorage not available.')
}
return false
}
}
}
Expand All @@ -320,14 +318,6 @@ Accordion.prototype.storeState = function ($section) {
var contentId = $button.getAttribute('aria-controls')
var contentState = $button.getAttribute('aria-expanded')

if (typeof contentId === 'undefined' && (typeof console === 'undefined' || typeof console.log === 'undefined')) {
console.error(new Error('No aria controls present in accordion section heading.'))
}

if (typeof contentState === 'undefined' && (typeof console === 'undefined' || typeof console.log === 'undefined')) {
console.error(new Error('No aria expanded present in accordion section heading.'))
}

// Only set the state when both `contentId` and `contentState` are taken from the DOM.
if (contentId && contentState) {
window.sessionStorage.setItem(contentId, contentState)
Expand Down
12 changes: 1 addition & 11 deletions package/govuk/all.js
Original file line number Diff line number Diff line change
Expand Up @@ -1055,9 +1055,7 @@ var helper = {
window.sessionStorage.removeItem(testString);
return result
} catch (exception) {
if ((typeof console === 'undefined' || typeof console.log === 'undefined')) {
console.log('Notice: sessionStorage not available.');
}
return false
}
}
};
Expand All @@ -1074,14 +1072,6 @@ Accordion.prototype.storeState = function ($section) {
var contentId = $button.getAttribute('aria-controls');
var contentState = $button.getAttribute('aria-expanded');

if (typeof contentId === 'undefined' && (typeof console === 'undefined' || typeof console.log === 'undefined')) {
console.error(new Error('No aria controls present in accordion section heading.'));
}

if (typeof contentState === 'undefined' && (typeof console === 'undefined' || typeof console.log === 'undefined')) {
console.error(new Error('No aria expanded present in accordion section heading.'));
}

// Only set the state when both `contentId` and `contentState` are taken from the DOM.
if (contentId && contentState) {
window.sessionStorage.setItem(contentId, contentState);
Expand Down
12 changes: 1 addition & 11 deletions package/govuk/components/accordion/accordion.js
Original file line number Diff line number Diff line change
Expand Up @@ -1040,9 +1040,7 @@ var helper = {
window.sessionStorage.removeItem(testString);
return result
} catch (exception) {
if ((typeof console === 'undefined' || typeof console.log === 'undefined')) {
console.log('Notice: sessionStorage not available.');
}
return false
}
}
};
Expand All @@ -1059,14 +1057,6 @@ Accordion.prototype.storeState = function ($section) {
var contentId = $button.getAttribute('aria-controls');
var contentState = $button.getAttribute('aria-expanded');

if (typeof contentId === 'undefined' && (typeof console === 'undefined' || typeof console.log === 'undefined')) {
console.error(new Error('No aria controls present in accordion section heading.'));
}

if (typeof contentState === 'undefined' && (typeof console === 'undefined' || typeof console.log === 'undefined')) {
console.error(new Error('No aria expanded present in accordion section heading.'));
}

// Only set the state when both `contentId` and `contentState` are taken from the DOM.
if (contentId && contentState) {
window.sessionStorage.setItem(contentId, contentState);
Expand Down
15 changes: 12 additions & 3 deletions package/govuk/overrides/_spacing.scss
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,14 @@ $_spacing-directions: (
/// Generate spacing override classes for the given property (e.g. margin)
/// for each point in the non-responsive spacing scale.
///
/// The classes in the format govuk-#{$property}-static-#{$spacing-point}
/// and govuk-\!-#{$property}-#{$direction}-static-#{$spacing-point} are deprecated.
/// For example: govuk-!-margin-static-2 or govuk-!-margin-top-static-2
///
/// Use classes in the format .govuk-\!-static-#{$property}-#{$spacing-point}
/// and .govuk-\!-static-#{$property}-#{$direction}-#{$spacing-point} instead.
/// For example: govuk-!-static-margin-2 or govuk-!-static-margin-top-2
///
/// @param {String} $property - Property to add spacing to (e.g. 'margin')
///
/// @example css
Expand All @@ -71,13 +79,14 @@ $_spacing-directions: (
/// @access private
@mixin _govuk-generate-static-spacing-overrides($property) {
@each $spacing-point in map-keys($govuk-spacing-points) {
.govuk-\!-#{$property}-static-#{$spacing-point} {
.govuk-\!-#{$property}-static-#{$spacing-point},
.govuk-\!-static-#{$property}-#{$spacing-point} {
#{$property}: govuk-spacing($spacing-point) !important;
}

@each $direction in $_spacing-directions {

.govuk-\!-#{$property}-#{$direction}-static-#{$spacing-point} {
.govuk-\!-#{$property}-#{$direction}-static-#{$spacing-point},
.govuk-\!-static-#{$property}-#{$direction}-#{$spacing-point} {
#{$property}-#{$direction}: govuk-spacing($spacing-point) !important;
}
}
Expand Down
2 changes: 1 addition & 1 deletion package/package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "govuk-frontend",
"description": "GOV.UK Frontend contains the code you need to start building a user interface for government platforms and services.",
"version": "4.3.0",
"version": "4.3.1",
"main": "govuk/all.js",
"module": "govuk-esm/all.mjs",
"exports": {
Expand Down