Ensure tests fail for browser exceptions #2933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-2933
colinrotherham
force-pushed
the
jest-promise-reject
branch
from
e2612f8 to
037225f
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-2933
36degrees
approved these changes
Oct 24, 2022
There was a problem hiding this comment.
Generally looks really good – have tested by recreating the issue we had in September (trying to access $module.dataset when $module was undefined) and we now get actually useful messages surfaced in the test output 🙌🏻
A minor nitpick and a suggestion for your consideration, but neither are blocking so happy to approve.
colinrotherham
force-pushed
the
package-updates
branch
from
d1c486b to
8ad0084
Compare
colinrotherham
force-pushed
the
jest-promise-reject
branch
from
037225f to
7f2745a
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-2933
colinrotherham
force-pushed
the
jest-promise-reject
branch
from
7f2745a to
dc0e45b
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-2933
colinrotherham
force-pushed
the
package-updates
branch
from
aa59153 to
57edd77
Compare
Only three unit test files remain which still need a jsdom environment override: ``` src/govuk/common.unit.test.mjs src/govuk/components/character-count/character-count.unit.test.mjs src/govuk/i18n.unit.test.mjs ```
colinrotherham
force-pushed
the
jest-promise-reject
branch
from
dc0e45b to
a170641
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-2933
This was referenced Nov 10, 2022
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures all browser tests (Puppeteer, jsdom) fail for unhandled browser exceptions
It does a few separate things:
process.emit('error', error)to ensure browser exceptions fail testsPrevents Jest Puppeteer incorrectly emittinguncaughtExceptionUpdate: The missing piece of the puzzle was (strangely) removing the
error.stackproperty before callingprocess.emit(). This ensures the error is logged in our test output, rather than blank linesPossibly related to jestjs/jest#6281