Change colour for current page link in the header to improve contrast when printing #3021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domoscargin
added
header
sass / css
Design System squad
and removed
awaiting triage
querkmachine
approved these changes
Dec 2, 2022
owenatgov
reviewed
Dec 5, 2022
There was a problem hiding this comment.
@MalcolmVonMoJ Looks good to me too 👍🏻
Before I give this the official github tick, I'd like to ask that you add a changelog entry and squash the commit history. We're happy to handle this if you prefer.
|
@owenatgov Can you do this please? I don't know how to squash in github. I went to add it to the changelog too, but mistook "feature release" for "future release" and put it in the wrong place. Undid that error, but I think someone else is best to squash and update the changelog as I'm not sure where it is. Also, one of the automated tests was failing and I am not sure what to do about it. |
owenatgov
approved these changes
Dec 5, 2022
owenatgov
force-pushed
the
patch-6
branch
2 times, most recently
from
4f56eea to
5c12c89
Compare
Changing the blue back to the brand colour `#1d70b8` when printing. The colour `#1d8feb` is presumably to contrast against the black `#0b0c0c` header, but when printing the header is white, so it makes sense to use a darker blue which contrasts better against white. Linting tests changes Removed trailing spaces and added blank line as per linting test errors Linting tests changes Removed blank line as per linting test errors (yep - the same one that the linter told me to add) Remove whitespace Update changelog with link to PR undid mistake
owenatgov
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing the blue back to the brand colour
#1d70b8when printing. The colour#1d8febis presumably to contrast against the black#0b0c0cheader, but when printing the header is white#ffffff, so it makes sense to use a darker blue which contrasts better against white.