[DO NOT MERGE] Use rollup-plugin-visualizer to gather some stats on the file #3109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Component JavaScript can be skipped as we also do for ‘dist’
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-3109
romaricpascal
force-pushed
the
rollup-plugin-visualizer
branch
from
b998618 to
b847e3a
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-3109
romaricpascal
force-pushed
the
rollup-plugin-visualizer
branch
from
b847e3a to
551a1e0
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-3109
Each type of chart available is generated in the 'public' folder so it can be served in the review app
romaricpascal
force-pushed
the
rollup-plugin-visualizer
branch
from
551a1e0 to
d510424
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-3109
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-3109
colinrotherham
force-pushed
the
rollup-standalone
branch
2 times, most recently
from
1c05ea0 to
abdf26b
Compare
colinrotherham
force-pushed
the
rollup-standalone
branch
6 times, most recently
from
721b159 to
7765b4a
Compare
5 tasks
7 tasks
|
Spike work is complete and perf work carries on in #3279 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A quick exploration of what rollup-plugin-visualizer could provide for keeping track of performance. This will require us to upgrade to Rollup 3, so is not a now thing. The plugin provides different visual representation of our library's modules:
It also provides two data formats that we could consume in scripts to derive information:
The final commit adds specific file names for each entry being built by rollup. This would help us collect stats about each separate component.