Tweak tab clicks to use event.currentTarget
#3248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-3248
colinrotherham
commented
Feb 3, 2023
colinrotherham
commented
Feb 6, 2023
src/govuk/components/tabs/tabs.mjs
Outdated
| */ | ||
| Tabs.prototype.onTabClick = function (event) { | ||
| if (!event.target.classList.contains('govuk-tabs__tab')) { |
There was a problem hiding this comment.
We've removed as event.currentTarget will be the tab link (not a child element)
We know the IE8 polyfill adds event.currentTarget support but just need to verify if it's clever enough to handle target vs currentTarget (might just alias them as the same thing)
There was a problem hiding this comment.
Yep from our polyfill
event.currentTarget = element;
event.relatedTarget = event.fromElement || null;
event.target = event.target || event.srcElement || element;Where element is this (current target)
We can skip our checks for “child DOM elements” on `event.target` by getting the tab link from `event.currentTarget` instead
colinrotherham
force-pushed
the
tab-click-target
branch
from
629211a to
a323c91
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-3248
36degrees
approved these changes
Feb 7, 2023
|
Might be worth updating the PR title and description to avoid confusion. |
colinrotherham
changed the title
event.currentTarget and share handlersevent.currentTarget
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few minor tweaks to Tabs to simplify our code in places
Find the tab link using
event.currentTargetPrevents us having to check for child elements getting the click
Move Tab bound handlers to constructorWe were recreating handlers multiple times per tabUpdate: Commit for 2) has been merged via: