-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump @percy/sdk-utils from 1.23.0 to 1.24.0 #3540
Bump @percy/sdk-utils from 1.23.0 to 1.24.0 #3540
Conversation
Bumps [@percy/sdk-utils](https://github.com/percy/cli/tree/HEAD/packages/sdk-utils) from 1.23.0 to 1.24.0. - [Release notes](https://github.com/percy/cli/releases) - [Commits](https://github.com/percy/cli/commits/v1.24.0/packages/sdk-utils) --- updated-dependencies: - dependency-name: "@percy/sdk-utils" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
27b2b87
to
513dc8b
Compare
shared/tasks/package.json
Outdated
@@ -33,5 +32,8 @@ | |||
"slash": "^5.0.0", | |||
"terser": "^5.17.1", | |||
"yargs-parser": "^21.1.1" | |||
}, | |||
"dependencies": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@romaricpascal Mind if we keep this as a devDependency
?
You probably wanted --save-dev
not --save
when fixing
Otherwise all the workspaces that import govuk-frontend-tasks
will install it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh yeah, forgot to check which kind of dependency it was before running the command , sorry 🤦🏻 I'll fix that 😊
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, just going to request changes before we merge this one
513dc8b
to
b0ee3b2
Compare
b0ee3b2
to
f22b757
Compare
For context, this one hit a Dependabot issue we caught with Fixed with: npm uninstall @percy/sdk-utils --workspace shared/tasks
npm install @percy/sdk-utils --workspace shared/tasks --save-dev |
Bumps @percy/sdk-utils from 1.23.0 to 1.24.0.
Release notes
Sourced from
@percy/sdk-utils
's releases.Commits
8de18f0
🔖 v1.24.0Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)