Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPIKE] Run the GOV.UK Prototype Kit locally #4056

Closed
wants to merge 1 commit into from

Conversation

colinrotherham
Copy link
Contributor

@colinrotherham colinrotherham commented Aug 8, 2023

This PR creates and installs an instance of GOV.UK Prototype Kit locally as part of #3759

After install, we use npm link to replace GOV.UK Frontend with ./packages/govuk-frontend

I'd like to spike using Percy to:

  1. Start the prototype
  2. Screenshot the prototype home page
  3. Screenshot the Manage your prototype page

This spots issues like missing fonts, assets etc

@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-4056 August 8, 2023 10:16 Inactive
@colinrotherham colinrotherham force-pushed the govuk-prototype-kit-review branch from bb9d047 to ea9db48 Compare August 8, 2023 10:26
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-4056 August 8, 2023 10:26 Inactive
@colinrotherham
Copy link
Contributor Author

Still seeing the following in the browser development console:

[Error] Failed to load resource: too many HTTP redirects (http://localhost:3000/manage-prototype/dependencies/govuk-frontend/govuk/assets/fonts/bold-b542beb274-v2.woff2, line 0)
[Error] Failed to load resource: too many HTTP redirects (http://localhost:3000/manage-prototype/dependencies/govuk-frontend/govuk/assets/fonts/light-94a07e06a1-v2.woff2, line 0)
[Error] Failed to load resource: too many HTTP redirects (http://localhost:3000/manage-prototype/dependencies/govuk-frontend/govuk/assets/images/govuk-crest-2x.png, line 0)
[Error] Failed to load resource: too many HTTP redirects (http://localhost:3000/manage-prototype/dependencies/govuk-frontend/govuk/assets/fonts/bold-affa96571d-v2.woff, line 0)
[Error] Failed to load resource: too many HTTP redirects (http://localhost:3000/manage-prototype/dependencies/govuk-frontend/govuk/assets/fonts/light-f591b13f7d-v2.woff, line 0)

This is with cherry picked commit 89166c9 from @romaricpascal

@colinrotherham colinrotherham force-pushed the govuk-prototype-kit-review branch from ea9db48 to f84d47b Compare August 8, 2023 15:24
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-4056 August 8, 2023 15:24 Inactive
@colinrotherham colinrotherham force-pushed the govuk-prototype-kit-review branch from f84d47b to b60cc33 Compare August 14, 2023 14:17
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-4056 August 14, 2023 14:17 Inactive
@colinrotherham colinrotherham force-pushed the govuk-prototype-kit-review branch from b60cc33 to 4948624 Compare August 15, 2023 14:49
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-4056 August 15, 2023 14:49 Inactive
@colinrotherham
Copy link
Contributor Author

@colinrotherham colinrotherham force-pushed the govuk-prototype-kit-review branch from 4948624 to 4ef6111 Compare August 18, 2023 11:37
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-4056 August 18, 2023 11:37 Inactive
@colinrotherham colinrotherham force-pushed the govuk-prototype-kit-review branch from 4ef6111 to 5275522 Compare August 18, 2023 13:23
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-4056 August 18, 2023 13:24 Inactive
@colinrotherham colinrotherham force-pushed the govuk-prototype-kit-review branch from 5275522 to dde269f Compare August 18, 2023 13:42
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-4056 August 18, 2023 13:43 Inactive
@colinrotherham colinrotherham force-pushed the govuk-prototype-kit-review branch from dde269f to 57220d8 Compare August 21, 2023 08:44
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-4056 August 21, 2023 08:44 Inactive
@colinrotherham colinrotherham force-pushed the govuk-prototype-kit-review branch from 57220d8 to e3c4269 Compare August 22, 2023 09:07
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-4056 August 22, 2023 09:07 Inactive
@colinrotherham colinrotherham force-pushed the govuk-prototype-kit-review branch from e3c4269 to bfc9c7e Compare August 31, 2023 13:57
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-4056 August 31, 2023 13:58 Inactive
@github-actions
Copy link

github-actions bot commented Aug 31, 2023

📋 Stats

File sizes

File Size
dist/govuk-frontend-4.6.0.min.css 118.07 KiB
dist/govuk-frontend-4.6.0.min.js 47.1 KiB
dist/govuk-frontend-ie8-4.6.0.min.css 79.27 KiB
packages/govuk-frontend/dist/govuk/all.bundle.js 77.65 KiB
packages/govuk-frontend/dist/govuk/all.bundle.mjs 72.94 KiB
packages/govuk-frontend/dist/govuk/all.mjs 3.84 KiB
packages/govuk-frontend/dist/govuk/govuk-frontend-component.mjs 359 B
packages/govuk-frontend/dist/govuk/govuk-frontend.min.css 120.49 KiB
packages/govuk-frontend/dist/govuk/govuk-frontend.min.js 37.89 KiB
packages/govuk-frontend/dist/govuk/i18n.mjs 5.83 KiB

Modules

File Size
all.mjs 69.04 KiB
components/accordion/accordion.mjs 21.91 KiB
components/button/button.mjs 4.71 KiB
components/character-count/character-count.mjs 22.03 KiB
components/checkboxes/checkboxes.mjs 5.69 KiB
components/error-summary/error-summary.mjs 6.01 KiB
components/exit-this-page/exit-this-page.mjs 16.61 KiB
components/header/header.mjs 3.84 KiB
components/notification-banner/notification-banner.mjs 4.55 KiB
components/radios/radios.mjs 4.68 KiB
components/skip-link/skip-link.mjs 3.74 KiB
components/tabs/tabs.mjs 9.32 KiB

View stats and visualisations on the review app


Action run for 5628cf4

@colinrotherham colinrotherham force-pushed the govuk-prototype-kit-review branch from bfc9c7e to 788bdaf Compare September 5, 2023 12:10
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-4056 September 5, 2023 12:10 Inactive
@colinrotherham colinrotherham force-pushed the govuk-prototype-kit-review branch from 788bdaf to 968f16b Compare September 22, 2023 13:16
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-4056 September 22, 2023 13:16 Inactive
@colinrotherham colinrotherham force-pushed the govuk-prototype-kit-review branch from 968f16b to 4e0077a Compare September 27, 2023 10:10
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-4056 September 27, 2023 10:11 Inactive
@colinrotherham colinrotherham force-pushed the govuk-prototype-kit-review branch from 4e0077a to 5628cf4 Compare September 29, 2023 13:13
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-4056 September 29, 2023 13:13 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants