Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPIKE] Update favicons (v5) #4185

Closed
wants to merge 8 commits into from
Closed

[SPIKE] Update favicons (v5) #4185

wants to merge 8 commits into from

Commits on Sep 28, 2023

  1. Update favicons

    - Updates favicons to use the new Tudor crown.
    - Removes apple-touch-icon sizes that are no longer in common use.
    - Adds SVG favicon.
    - Adds manifest file and icons for Android devices.
    
    The assets used in this commit are not final and are subject to change.
    querkmachine committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    fbcbdc2 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4233eaf View commit details
    Browse the repository at this point in the history
  3. Update asset path tests

    querkmachine committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    5b4022f View commit details
    Browse the repository at this point in the history
  4. Rename manifest file

    We anticipate that some servers may not be configured to correctly serve the .webmanifest content-type, so we're gonna stick with the (seemingly now legacy) .json
    extension for now.
    querkmachine committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    87b1bec View commit details
    Browse the repository at this point in the history
  5. Add tests for favicons

    querkmachine committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    02a9411 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    83e204e View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    6e1c89d View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2023

  1. Mark PNG icons as maskable

    The `maskable` keyword tells Android devices that the icon has been designed with a circular, central safe area, and that Android launchers can
    safely crop the edges of the icon instead of shrinking the icon down:
    https://css-tricks.com/maskable-icons-android-adaptive-icons-for-your-pwa/
    
    Despite the name, these are not 'masks' in the same way as the Safari icon. The Safari icon is an alpha mask, which is indicated using the
    `monochrome` keyword instead.
    querkmachine committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    e9d0dd3 View commit details
    Browse the repository at this point in the history