Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow HTML to be passed to error summary list #428

Merged
merged 2 commits into from
Jan 15, 2018

Conversation

36degrees
Copy link
Contributor

@36degrees 36degrees commented Jan 12, 2018

This component used to call the list component, but when that was removed it was updated with a simple loop over the items array.

This updates the loop to allow users to pass HTML for an entry in the list, and also ensures that if they do not provide an href the text or html does not get wrapped in a link.

https://trello.com/c/rdyDJMlK/575-allow-html-to-be-passed-to-error-summary-list

This component used to call the list component, but when that was removed it was updated with a simple loop over the items array.

This updates the loop to allow users to pass HTML for an entry in the list, and also ensures that if they do not provide an href the text or html does not get wrapped in a link.
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-428 January 12, 2018 12:16 Inactive
Copy link

@kr8n3r kr8n3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@36degrees 36degrees merged commit d71b753 into master Jan 15, 2018
@36degrees 36degrees deleted the allow-html-in-error-summary-list branch January 15, 2018 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants