Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log formatted warnings from Rollup #4306

Merged
merged 1 commit into from
Oct 5, 2023
+8 −7
Merged

Log formatted warnings from Rollup #4306

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions shared/tasks/scripts.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,14 +43,15 @@ export async function compileJavaScript([

// Create Rollup bundle(s)
for (const options of config.options) {
const bundle = await rollup({
...options,
const bundle = await rollup(options)

// Handle warnings as errors
onwarn(message) {
throw message
}
})
// Log warnings
config.warnings.flush()

// Handle warnings as errors
if (config.warnings.warningOccurred) {
throw new Error(`Rollup input '${modulePath}' logged warnings`)
}

// Compile JavaScript to output format
await Promise.all(
Expand Down