-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate element
parameter on button component
#4646
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-4646
January 15, 2024 16:11
Inactive
querkmachine
force-pushed
the
deprecate-button-element
branch
from
January 15, 2024 16:12
0c7b49b
to
fd1c723
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-4646
January 15, 2024 16:12
Inactive
📋 StatsFile sizes
Modules
View stats and visualisations on the review app Action run for fd1c723 |
Other changes to npm packagediff --git a/packages/govuk-frontend/dist/govuk/components/button/macro-options.json b/packages/govuk-frontend/dist/govuk/components/button/macro-options.json
index b3f6f6461..d922bbaa1 100644
--- a/packages/govuk-frontend/dist/govuk/components/button/macro-options.json
+++ b/packages/govuk-frontend/dist/govuk/components/button/macro-options.json
@@ -3,7 +3,7 @@
"name": "element",
"type": "string",
"required": false,
- "description": "HTML element for the button component – `input`, `button` or `a`. In most cases you will not need to set this as it will be configured automatically if `href` is provided."
+ "description": "HTML element for the button component – `input`, `button` or `a`. In most cases you will not need to set this as it will be configured automatically if `href` is provided. This parameter will be removed in the next major version."
},
{
"name": "text",
Action run for fd1c723 |
owenatgov
approved these changes
Jan 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the job!
3 tasks
Merged
This was referenced Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #4168, mark the
element
parameter as deprecated in the Nunjucks parameter docs and in the changelog.