-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new config schema allOf
condition support
#4791
Open
colinrotherham
wants to merge
12
commits into
main
Choose a base branch
from
schema-conditions
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-4791
February 23, 2024 17:39
Inactive
📋 StatsFile sizes
Modules
View stats and visualisations on the review app Action run for fd0af85 |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
colinrotherham
force-pushed
the
schema-conditions
branch
from
February 23, 2024 17:43
35220d1
to
936a8b8
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-4791
February 23, 2024 17:43
Inactive
colinrotherham
force-pushed
the
schema-conditions
branch
from
February 27, 2024 10:58
936a8b8
to
68ab9ae
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-4791
February 27, 2024 10:58
Inactive
This configured allowed types for config fields so we can check them in future
This prevents circular dependency issues
colinrotherham
force-pushed
the
schema-conditions
branch
from
March 8, 2024 16:17
68ab9ae
to
a94a414
Compare
Since we only pass in `DOMStringMap` values, this removes all tests for `normaliseDataset()` that don’t pass in strings We also prevent unnecessary data attributes (e.g. `data-module="govuk-accordion"’) from being merged into the config See: #4230
We can reduce the code we use by expanding dot-separated data-attributes at the point we read them This lets us remove `flattenConfigs()` since we can use nested configs everywhere
Do you want a `data-example="2024"` to stay as a string? Data attributes now understand component config schema types Extra checks added to guard against objects, arrays and non-finite numbers (NaN, Infinity)
…allow keys are set
colinrotherham
force-pushed
the
schema-conditions
branch
from
March 8, 2024 16:50
a94a414
to
fd0af85
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To offload some old code here's support for
allOf
schema conditions (alongsideanyOf
)Might never need this, but to prevent
i18n
orrememberExpanded
being accidentally overridden by null/undefined: