Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use KeyboardEvent.key over deprecated KeyboardEvent.keyCode in the Button component #4812

Merged
merged 2 commits into from
Mar 4, 2024
Merged

Use KeyboardEvent.key over deprecated KeyboardEvent.keyCode in the Button component #4812

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aca1043
Use `key` over deprecated `keyCode` in Button
36degrees Mar 1, 2024
6fce6ed
Document in CHANGELOG
36degrees Mar 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ For advice on how to use these release notes see [our guidance on staying up to
### Fixes

- [#4811: Use `KeyboardEvent.key` over deprecated `KeyboardEvent.keyCode` in the Tabs component](https://github.com/alphagov/govuk-frontend/pull/4811)
- [#4812: Use `KeyboardEvent.key` over deprecated `KeyboardEvent.keyCode` in the Button component](https://github.com/alphagov/govuk-frontend/pull/4812)

## 5.2.0 (feature release)

Expand Down
3 changes: 1 addition & 2 deletions packages/govuk-frontend/src/govuk/components/button/button.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ import { normaliseDataset } from '../../common/normalise-dataset.mjs'
import { ElementError } from '../../errors/index.mjs'
import { GOVUKFrontendComponent } from '../../govuk-frontend-component.mjs'

const KEY_SPACE = 32
const DEBOUNCE_TIMEOUT_IN_SECONDS = 1

/**
Expand Down Expand Up @@ -72,7 +71,7 @@ export class Button extends GOVUKFrontendComponent {
const $target = event.target

// Handle space bar only
if (event.keyCode !== KEY_SPACE) {
if (event.key !== ' ') {
return
}

Expand Down