-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the icon in the warning text component to match the defined text colour and background colour, rather than always being white on black #4906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📋 StatsFile sizes
Modules
View stats and visualisations on the review app Action run for 5f9e6ca |
Other changes to npm packagediff --git a/packages/govuk-frontend/dist/govuk/components/warning-text/_index.scss b/packages/govuk-frontend/dist/govuk/components/warning-text/_index.scss
index 10b0aa3d1..d221eecf6 100644
--- a/packages/govuk-frontend/dist/govuk/components/warning-text/_index.scss
+++ b/packages/govuk-frontend/dist/govuk/components/warning-text/_index.scss
@@ -27,11 +27,11 @@
// When a user customises their colours the background colour will often be removed.
// Adding a border to the component keeps it's shape as a circle.
- border: 3px solid govuk-colour("black");
+ border: 3px solid $govuk-text-colour;
border-radius: 50%;
- color: govuk-colour("white");
- background: govuk-colour("black");
+ color: $govuk-body-background-colour;
+ background: $govuk-text-colour;
font-size: 30px;
line-height: 29px;
Action run for 5f9e6ca |
owenatgov
changed the title
Use text colour and background colour variables in warning text
Update the icon in the warning text component to match the defined text colour and background colour, rather than always being white on black
Mar 28, 2024
owenatgov
force-pushed
the
sass-vars-in-wanring-text
branch
from
March 28, 2024 15:28
f91866a
to
5f9e6ca
Compare
36degrees
approved these changes
Apr 3, 2024
Merged
owenatgov
added a commit
that referenced
this pull request
Apr 29, 2024
Update the icon in the warning text component to match the defined text colour and background colour, rather than always being white on black
This was referenced Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Swaps out calls to
govuk-colour
in warning text to references to$govuk-text-colour
and$govuk-body-background-colour
.Why
During investigations into CSS custom properties as part of #4900, we noticed a number of places where a hypothetical change of colour scheme wouldn't properly permeate throughout the codebase. This establishes a direct relationship between the warning text component and the text colour and body background colour.