-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPIKE] Service Header component #4950
Commits on Jun 19, 2024
-
Configuration menu - View commit details
-
Copy full SHA for db4fac2 - Browse repository at this point
Copy the full SHA db4fac2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 150ed4e - Browse repository at this point
Copy the full SHA 150ed4eView commit details -
Configuration menu - View commit details
-
Copy full SHA for a63ec9c - Browse repository at this point
Copy the full SHA a63ec9cView commit details -
Update full-page examples, update header/phase banner styles
Update existing full-page examples that have a service name or navigation to use the Service Header component instead. Also update header and phase banner styles to work with service header: - Makes header border full-width in all circumstances - Adds content width container to phase banner
Configuration menu - View commit details
-
Copy full SHA for a8bffe2 - Browse repository at this point
Copy the full SHA a8bffe2View commit details -
Move header tag outside of header component
- Change a Notification Banner test that created a second banner role, as this created an accessibility failure with the header always being present in the template
Configuration menu - View commit details
-
Copy full SHA for c9b24e9 - Browse repository at this point
Copy the full SHA c9b24e9View commit details -
Fix failing accessibility test
Remove the 'with no options set' example from being tested as part of the standard accessibility tests. This is because the accessibility test tries to initialise the component's JS, but there is no HTML being rendered to initialise it against, returning an ElementError that Jest considers to be a test failure.
Configuration menu - View commit details
-
Copy full SHA for fdebb56 - Browse repository at this point
Copy the full SHA fdebb56View commit details -
Configuration menu - View commit details
-
Copy full SHA for e1112db - Browse repository at this point
Copy the full SHA e1112dbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 949ea39 - Browse repository at this point
Copy the full SHA 949ea39View commit details -
Configuration menu - View commit details
-
Copy full SHA for 426bf36 - Browse repository at this point
Copy the full SHA 426bf36View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0696d85 - Browse repository at this point
Copy the full SHA 0696d85View commit details -
Configuration menu - View commit details
-
Copy full SHA for 09a6a18 - Browse repository at this point
Copy the full SHA 09a6a18View commit details -
Configuration menu - View commit details
-
Copy full SHA for eb6d39b - Browse repository at this point
Copy the full SHA eb6d39bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1a8d302 - Browse repository at this point
Copy the full SHA 1a8d302View commit details -
Rework navigation so that list is hidden rather than nav
@selfthinker noted that having the entire `<nav>` element toggled means that the navigation landmark is inaccessible when the menu is closed. Not having the toggle within the landmark also means that assistive technology users wouldn't be able to jump to it easily. This commit moves the toggle button to within the `<nav>` element and tweaks the JS so that the `<ul>` has its visibility toggled instead.
Configuration menu - View commit details
-
Copy full SHA for 3188d47 - Browse repository at this point
Copy the full SHA 3188d47View commit details -
Configuration menu - View commit details
-
Copy full SHA for 13ad079 - Browse repository at this point
Copy the full SHA 13ad079View commit details -
Update for new component initialisation method
The method by which component JS is loaded and initialised changed in Frontend 5.4.0. This commit updates some of the references that didn't get caught while rebasing.
Configuration menu - View commit details
-
Copy full SHA for 10c6240 - Browse repository at this point
Copy the full SHA 10c6240View commit details -
Configuration menu - View commit details
-
Copy full SHA for abcadd2 - Browse repository at this point
Copy the full SHA abcadd2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 37bd556 - Browse repository at this point
Copy the full SHA 37bd556View commit details -
Configuration menu - View commit details
-
Copy full SHA for c54917e - Browse repository at this point
Copy the full SHA c54917eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2c67ecc - Browse repository at this point
Copy the full SHA 2c67eccView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8e67b18 - Browse repository at this point
Copy the full SHA 8e67b18View commit details
Commits on Jun 21, 2024
-
Partially revert phase banner changes
Partially reverts the changes from 2c67ecc These changes unfortunately broke some other use cases for the Service Header. After some discussion, we’ve decided that the phase banner will remain in its existing position, rather than trying to include it within the new section, to avoid the complications it introduces. The separation of the width container and service header container has been retained along with the moved start and end slots.
Configuration menu - View commit details
-
Copy full SHA for 213f9cc - Browse repository at this point
Copy the full SHA 213f9ccView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2817f65 - Browse repository at this point
Copy the full SHA 2817f65View commit details
Commits on Jun 24, 2024
-
Make navigation item list into flexbox
This fixes a few issues identified during testing, all caused by the `inline-block` approach to inlining these items. - Removes the extra whitespace from between each list item that screwed with the spacing between links and screen readers would pointlessly announce. - Fixes an NVDA issue in Firefox and Chrome <= 124 where it would read all of the links as a run-on sentence.
Configuration menu - View commit details
-
Copy full SHA for 736cab7 - Browse repository at this point
Copy the full SHA 736cab7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 03cd648 - Browse repository at this point
Copy the full SHA 03cd648View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8b08e6f - Browse repository at this point
Copy the full SHA 8b08e6fView commit details
Commits on Jun 25, 2024
-
Fix service name and navigation colliding in some situations
Adds some margin-right to the service name on tablet breakpoint so that the service name and navigation links no longer touch in certain circumstances. This could happen if the navigation and service name were collectively wide enough to fill the entire horizontal space at the present viewport size.
Configuration menu - View commit details
-
Copy full SHA for 4629276 - Browse repository at this point
Copy the full SHA 4629276View commit details -
Fix navigation extending off-screen in IE11
IE11 is tripping over the use of flex-wrap and is instead presenting all links as a single, horizontally scrolling row. This commit reverts the use of flexbox on IE11 (and IE10) specifically, falling back to the previous inline-block behaviour. This means that the previous accessibility issues are now present in IE11 again, but having the navigation wrap seems like a higher priority usability issue to address.
Configuration menu - View commit details
-
Copy full SHA for bb1a32c - Browse repository at this point
Copy the full SHA bb1a32cView commit details
Commits on Jun 27, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 91a9732 - Browse repository at this point
Copy the full SHA 91a9732View commit details
Commits on Jul 2, 2024
-
Revert "Move header tag outside of header component"
This reverts commit c9b24e9.
Configuration menu - View commit details
-
Copy full SHA for ca00b57 - Browse repository at this point
Copy the full SHA ca00b57View commit details -
Configuration menu - View commit details
-
Copy full SHA for eff46f1 - Browse repository at this point
Copy the full SHA eff46f1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 23bd8d9 - Browse repository at this point
Copy the full SHA 23bd8d9View commit details
Commits on Jul 3, 2024
-
Configuration menu - View commit details
-
Copy full SHA for f288d8f - Browse repository at this point
Copy the full SHA f288d8fView commit details
Commits on Jul 4, 2024
-
Configuration menu - View commit details
-
Copy full SHA for fbc582d - Browse repository at this point
Copy the full SHA fbc582dView commit details