Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPIKE] Service Header component #4950

Closed
wants to merge 34 commits into from
Closed

Commits on Jun 19, 2024

  1. Configuration menu
    Copy the full SHA
    db4fac2 View commit details
    Browse the repository at this point in the history
  2. Refactor styles

    querkmachine authored and domoscargin committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    150ed4e View commit details
    Browse the repository at this point in the history
  3. Disable Level AAA contrast check

    querkmachine authored and domoscargin committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    a63ec9c View commit details
    Browse the repository at this point in the history
  4. Update full-page examples, update header/phase banner styles

    Update existing full-page examples that have a service name or navigation to use the Service Header component instead.
    
    Also update header and phase banner styles to work with service header:
    
    - Makes header border full-width in all circumstances
    - Adds content width container to phase banner
    querkmachine authored and domoscargin committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    a8bffe2 View commit details
    Browse the repository at this point in the history
  5. Move header tag outside of header component

    - Change a Notification Banner test that created a second banner role, as this created an accessibility failure with the header always being present in the template
    querkmachine authored and domoscargin committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    c9b24e9 View commit details
    Browse the repository at this point in the history
  6. Fix failing accessibility test

    Remove the 'with no options set' example from being tested as part of the standard accessibility tests.
    
    This is because the accessibility test tries to initialise the component's JS, but there is no HTML being rendered to initialise it against, returning an ElementError that Jest considers to be a test failure.
    querkmachine authored and domoscargin committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    fdebb56 View commit details
    Browse the repository at this point in the history
  7. Add template tests

    querkmachine authored and domoscargin committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    e1112db View commit details
    Browse the repository at this point in the history
  8. Add example readme file

    querkmachine authored and domoscargin committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    949ea39 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    426bf36 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    0696d85 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    09a6a18 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    eb6d39b View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    1a8d302 View commit details
    Browse the repository at this point in the history
  14. Rework navigation so that list is hidden rather than nav

    @selfthinker noted that having the entire `<nav>` element toggled means that the navigation landmark is inaccessible when the menu is closed. Not having the toggle within the landmark also means that assistive technology users wouldn't be able to jump to it easily.
    
    This commit moves the toggle button to within the `<nav>` element and tweaks the JS so that the `<ul>` has its visibility toggled instead.
    querkmachine authored and domoscargin committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    3188d47 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    13ad079 View commit details
    Browse the repository at this point in the history
  16. Update for new component initialisation method

    The method by which component JS is loaded and initialised changed in Frontend 5.4.0. This commit updates some of the references that didn't get caught while rebasing.
    querkmachine authored and domoscargin committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    10c6240 View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    abcadd2 View commit details
    Browse the repository at this point in the history
  18. Update review app examples

    querkmachine authored and domoscargin committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    37bd556 View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    c54917e View commit details
    Browse the repository at this point in the history
  20. Configuration menu
    Copy the full SHA
    2c67ecc View commit details
    Browse the repository at this point in the history
  21. Update examples

    domoscargin committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    8e67b18 View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2024

  1. Partially revert phase banner changes

    Partially reverts the changes from 2c67ecc
    
    These changes unfortunately broke some other use cases for the Service Header.
    
    After some discussion, we’ve decided that the phase banner will remain in its existing position, rather than trying to include it within the new section, to avoid the complications it introduces.
    
    The separation of the width container and service header container has been retained along with the moved start and end slots.
    querkmachine committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    213f9cc View commit details
    Browse the repository at this point in the history
  2. Revert "Update examples"

    This reverts commit 8e67b18.
    querkmachine committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    2817f65 View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2024

  1. Make navigation item list into flexbox

    This fixes a few issues identified during testing, all caused by the
    `inline-block` approach to inlining these items.
    
    - Removes the extra whitespace from between each list item that
      screwed with the spacing between links and screen readers would
      pointlessly announce.
    - Fixes an NVDA issue in Firefox and Chrome <= 124 where it would read
      all of the links as a run-on sentence.
    querkmachine committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    736cab7 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    03cd648 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    8b08e6f View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2024

  1. Fix service name and navigation colliding in some situations

    Adds some margin-right to the service name on tablet breakpoint so that the service name and navigation links no longer touch in certain circumstances.
    
    This could happen if the navigation and service name were collectively wide enough to fill the entire horizontal space at the present viewport size.
    querkmachine committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    4629276 View commit details
    Browse the repository at this point in the history
  2. Fix navigation extending off-screen in IE11

    IE11 is tripping over the use of flex-wrap and is instead presenting all links as a single, horizontally scrolling row.
    
    This commit reverts the use of flexbox on IE11 (and IE10) specifically, falling back to the previous inline-block behaviour. This means that the previous accessibility issues are now present in IE11 again, but having the navigation wrap seems like a higher priority usability issue to address.
    querkmachine committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    bb1a32c View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2024

  1. Configuration menu
    Copy the full SHA
    91a9732 View commit details
    Browse the repository at this point in the history

Commits on Jul 2, 2024

  1. Revert "Move header tag outside of header component"

    This reverts commit c9b24e9.
    querkmachine committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    ca00b57 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    eff46f1 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    23bd8d9 View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2024

  1. Configuration menu
    Copy the full SHA
    f288d8f View commit details
    Browse the repository at this point in the history

Commits on Jul 4, 2024

  1. Configuration menu
    Copy the full SHA
    fbc582d View commit details
    Browse the repository at this point in the history