Fix input value not being set if the value was '0'

[patrickpatrickpatrick]

What

Input component now uses the govukAttributes macro to validate and format attributes. Test and example added for edge-case outlined in issue #4669.

Why

Issue #4669 outlines a case where setting 'value' of the Input component to 0 (integer) would not set the value of the input component. This is because the template logic would see '0' as false-y and so not set the value attribute. The govukAttributes takes this case into account and so using it means that this no longer occurs.

This is based from #4770. It adds tests and the input wrapper classes and attributes back.

[github-actions]

📋 Stats

File sizes

File	Size
dist/govuk-frontend-development.min.css	113.32 KiB
dist/govuk-frontend-development.min.js	42.21 KiB
packages/govuk-frontend/dist/govuk/all.bundle.js	87.21 KiB
packages/govuk-frontend/dist/govuk/all.bundle.mjs	81.95 KiB
packages/govuk-frontend/dist/govuk/all.mjs	4.17 KiB
packages/govuk-frontend/dist/govuk/govuk-frontend-component.mjs	359 B
packages/govuk-frontend/dist/govuk/govuk-frontend.min.css	113.3 KiB
packages/govuk-frontend/dist/govuk/govuk-frontend.min.js	42.2 KiB
packages/govuk-frontend/dist/govuk/i18n.mjs	5.55 KiB

Modules

File	Size (bundled)	Size (minified)
all.mjs	77.67 KiB	40.19 KiB
accordion.mjs	22.71 KiB	12.85 KiB
button.mjs	5.98 KiB	2.69 KiB
character-count.mjs	22.4 KiB	9.92 KiB
checkboxes.mjs	5.83 KiB	2.83 KiB
error-summary.mjs	7.89 KiB	3.46 KiB
exit-this-page.mjs	17.1 KiB	9.26 KiB
header.mjs	4.46 KiB	2.6 KiB
notification-banner.mjs	6.26 KiB	2.62 KiB
password-input.mjs	15.15 KiB	7.25 KiB
radios.mjs	4.83 KiB	2.38 KiB
skip-link.mjs	4.39 KiB	2.18 KiB
tabs.mjs	10.13 KiB	6.11 KiB

View stats and visualisations on the review app

---

Action run for 913b771

[36degrees]

Thanks for picking this up and congrats on your first contribution to GOV.UK Frontend on the team 😎 🎉

There's a couple of things that aren't quite right at the minute – in particular it looks like the changes in #4770 might have been out of date with some other changes to add the autocapitalize attribute, sorry we'd missed that!

Let me know if it'd be helpful to chat through any of this or if you've got any questions!

[36degrees]

It looks like this has changed from #4770 and changes the behaviour slightly.

Previously, if params.autocomplete wasn't set, we wouldn't output an autocomplete attribute.

Now, if params.autocomplete isn't set, we output a default autocomplete="none" which isn't valid.

This is one of the reasons the tests are failing – we run an html validator against all of the examples and it's erroring with '"none" is not a valid autocomplete token or field name'.

[36degrees]

issue It looks like the autocapitalize attribute was added in #4442, after the work in #4770 was done, so this will need adding to the new govukAttributes call.

(There's a corresponding test for this which we need to keep too)

[36degrees]

issue Why have these tests been removed?

[36degrees]

question Is the casting definitely necessary here? My understanding was that YAML should treat this is an integer already.

[36degrees]

praise Thanks for adding a test for this 🙌🏻

[36degrees]

This is looking great, thanks for addressing those comments.

One last thing – we'll want to add a changelog entry so that users know we've fixed this.

For a change like this we'd usually list it under 'Fixes', and just use the PR title, crediting anyone involved or reporting or fixing it as appropriate.

It might be worth making the PR title slightly more descriptive so we end up with something like this:

### Fixes

We've made fixes to GOV.UK Frontend in the following pull requests:

<!-- Existing fixes already in the changelog -->
- [#4963: Fix input value not being set if the value was '0'](https://github.com/alphagov/govuk-frontend/pull/4963) – thanks to @ dwp-dmitri-algazin for reporting this issue

[36degrees]

Looks good to me! 🙌🏻