Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make root all.scss a proxy for index.scss #4984

Merged
merged 1 commit into from
May 17, 2024
Merged

Make root all.scss a proxy for index.scss #4984

merged 1 commit into from
May 17, 2024

Conversation

36degrees
Copy link
Contributor

In #4955 we renamed all of the entrypoints within the individual layers from all.scss to index.scss, leaving all.scss in place as an alias that outputs a deprecation warning.

We also inadvertently introduced an index.scss in the root ‘govuk’ folder but with identical contents to all.scss.

We ultimately intend to rename this root entrypoint to index.scss to be consistent with the other changes, but this requires further changes to our documentation, entrypoints in package.json etc.

In order to get the next release out, we’re just going to make all.scss a proxy for index.scss, without adding a deprecation warning.

We’ll make those changes and introduce a deprecation warning in a future release.

In #4955 we renamed all of the entrypoints within the individual layers from `all.scss` to `index.scss`, leaving `all.scss` in place as an alias that outputs a deprecation warning.

We also inadvertently introduced an `index.scss` in the root ‘govuk’ folder but with identical contents to `all.scss`. [1]

We ultimately intend to rename this root entrypoint to `index.scss` to be consistent with the other changes, but this requires further changes to our documentation, entrypoints in package.json etc.

In order to get the next release out, we’re just going to make `all.scss` a proxy for `index.scss`, without adding a deprecation warning.

We’ll make those changes and introduce a deprecation warning in a future release.

[1]: https://github.com/alphagov/govuk-frontend/pull/4955/files#diff-ec46cef55fb94c8061eaf2fd3f241998f9a13d56fdad7018fe1712e00d5ae3aa
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-4984 May 17, 2024 09:24 Inactive
Copy link

📋 Stats

File sizes

File Size
dist/govuk-frontend-development.min.css 113.32 KiB
dist/govuk-frontend-development.min.js 42.34 KiB
packages/govuk-frontend/dist/govuk/all.bundle.js 88.16 KiB
packages/govuk-frontend/dist/govuk/all.bundle.mjs 82.83 KiB
packages/govuk-frontend/dist/govuk/all.mjs 981 B
packages/govuk-frontend/dist/govuk/govuk-frontend-component.mjs 359 B
packages/govuk-frontend/dist/govuk/govuk-frontend.min.css 113.3 KiB
packages/govuk-frontend/dist/govuk/govuk-frontend.min.js 42.33 KiB
packages/govuk-frontend/dist/govuk/i18n.mjs 5.55 KiB
packages/govuk-frontend/dist/govuk/init.mjs 4.86 KiB

Modules

File Size (bundled) Size (minified)
all.mjs 78.45 KiB 40.31 KiB
accordion.mjs 22.71 KiB 12.85 KiB
button.mjs 5.98 KiB 2.69 KiB
character-count.mjs 22.4 KiB 9.92 KiB
checkboxes.mjs 5.83 KiB 2.83 KiB
error-summary.mjs 7.89 KiB 3.46 KiB
exit-this-page.mjs 17.1 KiB 9.26 KiB
header.mjs 4.46 KiB 2.6 KiB
notification-banner.mjs 6.26 KiB 2.62 KiB
password-input.mjs 15.15 KiB 7.25 KiB
radios.mjs 4.83 KiB 2.38 KiB
skip-link.mjs 4.39 KiB 2.18 KiB
tabs.mjs 10.13 KiB 6.11 KiB

View stats and visualisations on the review app


Action run for 9235de4

Copy link

Other changes to npm package

diff --git a/packages/govuk-frontend/dist/govuk/all.scss b/packages/govuk-frontend/dist/govuk/all.scss
index d906d5093..1d57cf86e 100644
--- a/packages/govuk-frontend/dist/govuk/all.scss
+++ b/packages/govuk-frontend/dist/govuk/all.scss
@@ -1,11 +1,3 @@
-@import "base";
-
-@import "core/index";
-@import "objects/index";
-
-@import "components/index";
-
-@import "utilities/index";
-@import "overrides/index";
+@import "index";
 
 /*# sourceMappingURL=all.scss.map */

Action run for 9235de4

@36degrees 36degrees merged commit b5c1293 into main May 17, 2024
49 checks passed
@36degrees 36degrees deleted the root-all-index branch May 17, 2024 10:01
domoscargin pushed a commit that referenced this pull request Jun 19, 2024
Make root `all.scss` a proxy for `index.scss`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

3 participants