Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix details expanded state not announced on iOS #5089

Merged
merged 1 commit into from
Sep 25, 2024
Merged

Fix details expanded state not announced on iOS #5089

merged 1 commit into from
Sep 25, 2024

Commits on Sep 25, 2024

  1. Fix details expanded state not announced on iOS 

    For some reason, setting `display: inline-block` on the summary means that VoiceOver on iOS no longer announces the expanded state of the `<details>` element [1].

We were using `display: inline-block` so that the interactive area and the focus state (when visible) were constrained to the text within the `<summary>`.

We can achieve the same thing by using `display: block` with `width: fit-content`.

[1]: https://bugs.webkit.org/show_bug.cgi?id=230408
    @36degrees @owenatgov
    36degrees authored and owenatgov committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    00371fa View commit details
    Browse the repository at this point in the history