Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant tag CSS from phase banner #5090

Merged
merged 2 commits into from
Jun 18, 2024
Merged

Remove redundant tag CSS from phase banner #5090

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c83efb2
Remove redundant tag CSS from phase banner
36degrees Jun 18, 2024
3d84c82
Document in CHANGELOG
36degrees Jun 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ We've made fixes to GOV.UK Frontend in the following pull requests:
- [#5044: Remove session storage checks from accordion JavaScript](https://github.com/alphagov/govuk-frontend/pull/5044)
- [#5060: Reintroduce additional bottom margin to Error Summary content](https://github.com/alphagov/govuk-frontend/pull/5060)
- [#5070: Fix alignment of content in conditional checkboxes and radio buttons](https://github.com/alphagov/govuk-frontend/pull/5070)
- [#5090: Remove redundant tag CSS from phase banner](https://github.com/alphagov/govuk-frontend/pull/5090)

## 5.4.0 (Feature release)

Expand Down
8 changes: 0 additions & 8 deletions packages/govuk-frontend/src/govuk/components/phase-banner/_index.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,14 +25,6 @@
margin-right: govuk-spacing(2);
}
}

// When forced colour mode is active, for example to provide high contrast,
// the background colour of the tag is the same as the rest of the page. To ensure
// that the tag is perceived as separate to the rest of the text in the phase banner,
// it is made bold.
@media screen and (forced-colors: active) {
font-weight: bold;
}
}

.govuk-phase-banner__text {
Expand Down
Loading