Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove scope=row attribute from non-th elements #527

Merged
merged 3 commits into from
Feb 15, 2018
Merged

Remove scope=row attribute from non-th elements #527

merged 3 commits into from
Feb 15, 2018

Conversation

kr8n3r
Copy link

@kr8n3r kr8n3r commented Feb 13, 2018 •
edited
Loading

In HTML5 scope attribute should only be used on <th> elements according to https://dequeuniversity.com/rules/axe/1.1/scope

This PR removes the wrongly placed scope attribute on <td>s
Fixes #526

@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-527 February 13, 2018 15:49 Inactive
@kr8n3r kr8n3r force-pushed the fix-table-scope-attribute-placement branch from 09ed7c6 to d7498ce Compare February 13, 2018 16:51
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-527 February 13, 2018 16:51 Inactive
@kr8n3r
Copy link
Author

kr8n3r commented Feb 14, 2018

will need to be updated with #528

alex-ju
alex-ju approved these changes Feb 14, 2018
View reviewed changes
Copy link
Contributor

@alex-ju alex-ju left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

don't forget to update the changelog file

@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-527 February 14, 2018 16:53 Inactive
@kr8n3r kr8n3r force-pushed the fix-table-scope-attribute-placement branch from 9a95888 to f901d4d Compare February 15, 2018 11:26
@kr8n3r kr8n3r merged commit 465ff62 into master Feb 15, 2018
@kr8n3r kr8n3r deleted the fix-table-scope-attribute-placement branch February 15, 2018 11:41
@alex-ju alex-ju mentioned this pull request Feb 20, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alex-ju alex-ju alex-ju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kr8n3r @alex-ju @govuk-design-system-ci