Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ‘complex header’ example to review app #5275

Merged
merged 3 commits into from
Sep 3, 2024

Conversation

querkmachine
Copy link
Member

@querkmachine querkmachine commented Aug 29, 2024

Mulling over a full-page example that shows the Service navigation component in-situ with the GOV.UK header, phase banner, and other elements that usually appear at the top of a page.

Changes

  • Add 'Companies you follow (service navigation with service name)' full-page example, based on part of the Companies House WebFiling service. This example demonstrates:
    • The Service navigation component, with navigation links and service name/URL included.
    • The full-width border variant of the GOV.UK header component.
    • How the GOV.UK header, Service navigation, Phase banner, and Back link/Breadcrumbs components are placed relative to one another.
  • Add 'Companies you follow (service navigation with slots)' full-page example. This one additionally demonstrates:
    • The use of slots within the Service navigation component.
    • How the HTML elements and landmarks differ when the service name is not included in the Service navigation component.
  • Updates other examples that included navigation within the GOV.UK header component to either remove the navigation, or to move it to within the Service navigation component.

@querkmachine querkmachine requested review from CharlotteDowns and a team August 29, 2024 15:59
@querkmachine querkmachine self-assigned this Aug 29, 2024
Copy link

github-actions bot commented Aug 29, 2024

📋 Stats

File sizes

File Size
dist/govuk-frontend-development.min.css 118.4 KiB
dist/govuk-frontend-development.min.js 43.63 KiB
packages/govuk-frontend/dist/govuk/all.bundle.js 90.19 KiB
packages/govuk-frontend/dist/govuk/all.bundle.mjs 84.69 KiB
packages/govuk-frontend/dist/govuk/all.mjs 1.05 KiB
packages/govuk-frontend/dist/govuk/govuk-frontend-component.mjs 359 B
packages/govuk-frontend/dist/govuk/govuk-frontend.min.css 118.39 KiB
packages/govuk-frontend/dist/govuk/govuk-frontend.min.js 43.62 KiB
packages/govuk-frontend/dist/govuk/i18n.mjs 5.55 KiB
packages/govuk-frontend/dist/govuk/init.mjs 4.97 KiB

Modules

File Size (bundled) Size (minified)
all.mjs 81.8 KiB 41.48 KiB
accordion.mjs 23.5 KiB 12.39 KiB
button.mjs 5.98 KiB 2.69 KiB
character-count.mjs 22.4 KiB 9.92 KiB
checkboxes.mjs 5.83 KiB 2.83 KiB
error-summary.mjs 7.89 KiB 3.46 KiB
exit-this-page.mjs 17.1 KiB 9.26 KiB
header.mjs 4.46 KiB 2.6 KiB
notification-banner.mjs 6.26 KiB 2.62 KiB
password-input.mjs 15.15 KiB 7.25 KiB
radios.mjs 4.83 KiB 2.38 KiB
service-navigation.mjs 4.46 KiB 2.69 KiB
skip-link.mjs 4.39 KiB 2.18 KiB
tabs.mjs 10.05 KiB 6.06 KiB

View stats and visualisations on the review app


Action run for 0d2370a

We don’t expect users to use the navigation function of the header component anymore, instead preferring the service navigation component.
@querkmachine querkmachine marked this pull request as ready for review August 30, 2024 09:44
@querkmachine querkmachine marked this pull request as draft September 2, 2024 10:34
Create examples with and without the service name in the Service navigation component to demonstrate differences in HTML landmarks
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-5275 September 2, 2024 11:10 Inactive
@querkmachine querkmachine marked this pull request as ready for review September 2, 2024 11:27
Copy link
Contributor

@CharlotteDowns CharlotteDowns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, I guess it will pull through the changes from #5278 when we merge it

@querkmachine querkmachine merged commit 5ae4fe1 into main Sep 3, 2024
51 checks passed
@querkmachine querkmachine deleted the review-app-complex-header branch September 3, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants