Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate File upload component's value parameter #5330

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

querkmachine
Copy link
Member

Deprecates the value parameter on the File upload component's Nunjucks macro, as a precursor to removing it with #5311.

Although it is likely to be safe to remove the parameter immediately, as it's already non-functional in all modern browsers, we're playing it safe and putting it through the normal deprecation and removal process just in case any implementations or ports expect the parameter to exist.

Changes

  • Marks the parameter as deprecated in Nunjucks macro documentation.
  • Adds a changelog entry recommending that users remove it, if it's being used.

Copy link

github-actions bot commented Sep 16, 2024

📋 Stats

File sizes

File Size
dist/govuk-frontend-development.min.css 118.41 KiB
dist/govuk-frontend-development.min.js 42.93 KiB
packages/govuk-frontend/dist/govuk/all.bundle.js 91.34 KiB
packages/govuk-frontend/dist/govuk/all.bundle.mjs 85.77 KiB
packages/govuk-frontend/dist/govuk/all.mjs 1.18 KiB
packages/govuk-frontend/dist/govuk/govuk-frontend-component.mjs 1.74 KiB
packages/govuk-frontend/dist/govuk/govuk-frontend.min.css 118.4 KiB
packages/govuk-frontend/dist/govuk/govuk-frontend.min.js 42.92 KiB
packages/govuk-frontend/dist/govuk/i18n.mjs 5.55 KiB
packages/govuk-frontend/dist/govuk/init.mjs 6.85 KiB

Modules

File Size (bundled) Size (minified)
all.mjs 81.9 KiB 40.37 KiB
accordion.mjs 25.46 KiB 12.93 KiB
button.mjs 7.96 KiB 3.31 KiB
character-count.mjs 24.39 KiB 10.5 KiB
checkboxes.mjs 7.81 KiB 3.42 KiB
error-summary.mjs 9.87 KiB 4.07 KiB
exit-this-page.mjs 19.08 KiB 9.86 KiB
header.mjs 6.46 KiB 3.22 KiB
notification-banner.mjs 8.24 KiB 3.23 KiB
password-input.mjs 17.13 KiB 7.86 KiB
radios.mjs 6.81 KiB 2.98 KiB
service-navigation.mjs 6.44 KiB 3.26 KiB
skip-link.mjs 6.4 KiB 2.76 KiB
tabs.mjs 12.04 KiB 6.67 KiB

View stats and visualisations on the review app


Action run for 8a95be4

Copy link

github-actions bot commented Sep 16, 2024

Other changes to npm package

diff --git a/packages/govuk-frontend/dist/govuk/components/file-upload/macro-options.json b/packages/govuk-frontend/dist/govuk/components/file-upload/macro-options.json
index 5db62cb10..c7608479a 100644
--- a/packages/govuk-frontend/dist/govuk/components/file-upload/macro-options.json
+++ b/packages/govuk-frontend/dist/govuk/components/file-upload/macro-options.json
@@ -15,7 +15,7 @@
         "name": "value",
         "type": "string",
         "required": false,
-        "description": "Optional initial value of the input."
+        "description": "Deprecated. Optional initial value of the input."
     },
     {
         "name": "disabled",

Action run for 8a95be4

Copy link
Contributor

@owenatgov owenatgov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good. I'll await a content person to approve it.

@querkmachine querkmachine force-pushed the file-upload-deprecate-value-param branch from cb6d1e2 to 869a8b0 Compare October 10, 2024 16:47
@querkmachine querkmachine force-pushed the file-upload-deprecate-value-param branch from 869a8b0 to 8a95be4 Compare October 11, 2024 08:04
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-5330 October 11, 2024 08:04 Inactive
@querkmachine querkmachine merged commit 782fba5 into main Oct 11, 2024
50 checks passed
@querkmachine querkmachine deleted the file-upload-deprecate-value-param branch October 11, 2024 08:14
@owenatgov owenatgov mentioned this pull request Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants