Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add brand color for SFO #5389

Merged
merged 2 commits into from
Oct 10, 2024
Merged

Add brand color for SFO #5389

merged 2 commits into from
Oct 10, 2024

Conversation

ChrisBAshton
Copy link
Contributor

Copy link

github-actions bot commented Oct 8, 2024

📋 Stats

File sizes

File Size
dist/govuk-frontend-development.min.css 118.41 KiB
dist/govuk-frontend-development.min.js 43.63 KiB
packages/govuk-frontend/dist/govuk/all.bundle.js 90.19 KiB
packages/govuk-frontend/dist/govuk/all.bundle.mjs 84.69 KiB
packages/govuk-frontend/dist/govuk/all.mjs 1.05 KiB
packages/govuk-frontend/dist/govuk/govuk-frontend-component.mjs 359 B
packages/govuk-frontend/dist/govuk/govuk-frontend.min.css 118.4 KiB
packages/govuk-frontend/dist/govuk/govuk-frontend.min.js 43.62 KiB
packages/govuk-frontend/dist/govuk/i18n.mjs 5.55 KiB
packages/govuk-frontend/dist/govuk/init.mjs 4.97 KiB

Modules

File Size (bundled) Size (minified)
all.mjs 81.8 KiB 41.48 KiB
accordion.mjs 23.5 KiB 12.39 KiB
button.mjs 5.98 KiB 2.69 KiB
character-count.mjs 22.4 KiB 9.92 KiB
checkboxes.mjs 5.83 KiB 2.83 KiB
error-summary.mjs 7.89 KiB 3.46 KiB
exit-this-page.mjs 17.1 KiB 9.26 KiB
header.mjs 4.46 KiB 2.6 KiB
notification-banner.mjs 6.26 KiB 2.62 KiB
password-input.mjs 15.15 KiB 7.25 KiB
radios.mjs 4.83 KiB 2.38 KiB
service-navigation.mjs 4.46 KiB 2.69 KiB
skip-link.mjs 4.39 KiB 2.18 KiB
tabs.mjs 10.05 KiB 6.06 KiB

View stats and visualisations on the review app


Action run for 6b11203

@ChrisBAshton ChrisBAshton marked this pull request as ready for review October 8, 2024 08:51
Copy link

github-actions bot commented Oct 8, 2024

Other changes to npm package

diff --git a/packages/govuk-frontend/dist/govuk/settings/_colours-organisations.scss b/packages/govuk-frontend/dist/govuk/settings/_colours-organisations.scss
index 92d3acebf..41f8c7b25 100644
--- a/packages/govuk-frontend/dist/govuk/settings/_colours-organisations.scss
+++ b/packages/govuk-frontend/dist/govuk/settings/_colours-organisations.scss
@@ -180,6 +180,9 @@ $_govuk-organisation-colours: (
     colour: #002663,
     deprecation-message: "`scotland-office` became `office-of-the-secretary-of-state-for-scotland` in 2018."
   ),
+  "serious-fraud-office": (
+    colour: #82368c
+  ),
   "uk-export-finance": (
     colour: #cf102d
   ),

Action run for 6b11203

@querkmachine
Copy link
Member

Have discussed this on Slack.

Although we wouldn't typically include non-ministerial departments in this list—as all except for HMRC aren't included within the HMG Identity System, which we use as our source of truth—the Serious Fraud Office is in the process of migrating to use GOV.UK as their primary online presence. They don't use the same brand colour as their parent organisation (AGO), thus need their brand colour independently available.

On this basis, I think it's reasonable that we make an exception and add SFO to our organisation colour palette.

@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-5389 October 9, 2024 14:15 Inactive
Copy link
Member

@querkmachine querkmachine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the changelog entry might need tweaking a bit but we can do that during the release party later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants