Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPIKE] Use TypeScript for the Accordion's defaults immutability #5493

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[SPIKE] Use TypeScript for the Accordion's defaults immutability #5493

wants to merge 1 commit into from
+33 −7

Commits on Nov 11, 2024

  1. Use TypeScript check for the Accordion's defaults immutability 

    `Object.freeze` only does a shallow freeze of the object, meaning we have nothing checking our code
against something setting one of the keys of `i18n`.

The `ReadonlyDeep` type from `type-fest` allows TypeScript to check that even deep properties cannot be updated by our code.
    @romaricpascal
    romaricpascal committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    3042948 View commit details
    Browse the repository at this point in the history