Code

[WIP][SPIKE] Accordion refactorings#5551

Code

Draft

romaricpascal wants to merge 9 commits intomainalphagov/govuk-frontend:mainfrom accordion-section-componentalphagov/govuk-frontend:accordion-section-componentCopy head branch name to clipboard

+270-186

Commits

Commits on Feb 28, 2025

• Avoid properties for class names used only once

  

  36degrees

  authored and

  romaricpascal

  committed
  3127f88

  Copy full SHA for 3127f88

• Improve class property names

  

  36degrees

  authored and

  romaricpascal

  committed
  3cec528

  Copy full SHA for 3cec528

• [WIP] Use helper function for creating elements

  

  36degrees

  authored and

  romaricpascal

  committed
  af18710

  Copy full SHA for af18710

• Move class and modifier strings outside of the Accordion class

  Show description for 2cff2cf
  romaricpascal

  committed
  2cff2cf

  Copy full SHA for 2cff2cf

• Move button creation closer to where it starts getting used

  romaricpascal

  committed
  d5e12b7

  Copy full SHA for d5e12b7

• Extract creation of the summary in its own method

  Show description for 3cdac0b
  romaricpascal

  committed
  3cdac0b

  Copy full SHA for 3cdac0b

• Extract creation of the Show/Hide toggle in its own method

  Show description for 0c83b08
  romaricpascal

  committed
  0c83b08

  Copy full SHA for 0c83b08

• Extract creation of section's heading text in its own method

  romaricpascal

  committed
  4d2686f

  Copy full SHA for 4d2686f

• Replace calls to appendChild with new option in createElement

  Show description for 6c61aa5
  romaricpascal

  committed
  6c61aa5

  Copy full SHA for 6c61aa5