Fix spelling of the colour fuchsia. #571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-571
36degrees
force-pushed
the
we-cant-spell-fuchsia
branch
from
d052d9c
to
8c87d97
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-571
|
Could we reference the original issue, and if possible credit the original contributor? |
|
Good call – done. |
36degrees
force-pushed
the
we-cant-spell-fuchsia
branch
from
8c87d97
to
fdd1f65
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-571
|
Any thoughts on if this should / could go out with a depreciation warning and not as a breaking change? Unsure if that's possible or not. |
|
It's something we'd like to explore in the future, but we're not set up for that yet. As only a limited number of beta partners are using it, and I would be very surprised if any of them are using this colour in their applications, I'm happy we can do this as a breaking change. |
kr8n3r
approved these changes
Mar 5, 2018
36degrees
force-pushed
the
we-cant-spell-fuchsia
branch
from
fdd1f65
to
d3f5510
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As raised in alphagov/govuk_elements#561