Add error summary examples, add margin to error summary #583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add examples of how the error summary component interacts with other elements on the page, in both a ‘one thing per page’ context and where multiple form controls are provided.
This adds a bottom margin to the error summary component. The error summary should always be the first thing on the page, after any breadcrumbs or back link. This means it will always appear before a heading, in which case we know that we will always need to add a margin to separate it from the heading.
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-583
|
@NickColley Happy with the changelog entry? |
|
@36degrees would say it's a breaking change maybe? but private beta happy to approve |
|
Fair – it changes the layout of that component considerably. |
36degrees
force-pushed
the
add-error-summary-examples
branch
from
64db3b5 to
2652c8e
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add examples of how the error summary component interacts with other elements on the page, in both a ‘one thing per page’ context and where multiple form controls are provided.
Add a bottom margin to error summary component – the error summary should always be the first thing on the page, after any breadcrumbs or back link. This means it will always appear before a heading, in which case we know that we will always need to add a margin to separate it from the heading.
https://trello.com/c/hg7MaHJk/809-think-about-how-the-error-summary-works-in-context-especially-in-a-one-thing-per-page-context