Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make section break line 1px instead of 2px #585

Merged
merged 2 commits into from
Mar 8, 2018
Merged

make section break line 1px instead of 2px #585

merged 2 commits into from
Mar 8, 2018

Conversation

joelanman
Copy link
Contributor

fixes #577

@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-585 March 7, 2018 14:48 Inactive
NickColley
NickColley previously requested changes Mar 7, 2018
View reviewed changes
Copy link
Contributor

@NickColley NickColley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR Joe.

Have you tested this in some browsers?

As far as I know this would result in a section break that still looks odd.

Since the top of the border will still be there (as is the default in a lot of user-agents)

@NickColley NickColley dismissed their stale review March 7, 2018 14:51

Nevermind, I see they're reset above :)

@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-585 March 7, 2018 14:56 Inactive
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-585 March 8, 2018 10:27 Inactive
@joelanman joelanman force-pushed the fix-sectio-break-border branch from 4f2d909 to 3a916db Compare March 8, 2018 10:38
@joelanman joelanman merged commit 86223f5 into master Mar 8, 2018
@joelanman joelanman deleted the fix-sectio-break-border branch March 8, 2018 10:46
@NickColley NickColley mentioned this pull request Mar 8, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NickColley NickColley NickColley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

govuk-section-break line width is too large
3 participants
@joelanman @NickColley @govuk-design-system-ci